Conversation
kajoseph
reviewed
Jan 9, 2026
kajoseph
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Use tsx to run mocha test scripts in typescript packages. The purpose of this is to standardize bitcore typescript testing. No typescript tests will need to build.
📦 Packages
The packages with typescript being added:
bitcore-cli: Replaced ts-node with tsx.bitcore-client: Already uses tsx, added type checking.bitcore-node: Added tsx to unit tests. Integration tests already use tsx; added type checking. Modified test imports to work with tsx.bitcore-wallet-client: Replaced ts-node with tsx.bitcore-wallet-service: Replaced ts-node with tsx.crypto-wallet-core: Already uses tsx: added type checking.