Conversation
Member
Author
|
This is not quite ready yet, so don't review. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 68 out of 71 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
Fix cmake file Factors Constrained Optimizers
dellaert
force-pushed
the
feature/gtsam_optimizers
branch
from
c263d1d to
58c351b
Compare
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
Co-authored-by: dellaert <10515273+dellaert@users.noreply.github.com>
[WIP] Remove constrained optimizers and use GTSAM versions
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 68 out of 71 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yetongumich
approved these changes
Feb 6, 2026
Collaborator
yetongumich
left a comment
yetongumich
left a comment
There was a problem hiding this comment.
LGTM as long as CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the constrained optimizers (Penalty, Augmented Lagrangian) as they were developed in this repo and now includes/links with the versions in
gtsam/constrained, which were ported by @yetongatech to GTSAM, and refactored there.This is only half the story, the other story is in #404 404, which also switches to the constraints in GTSAM