Syntax highlighting enabled for languages other than Objective-C#79
Open
suranyami wants to merge 7 commits intobrotherbard:experimentalfrom
Open
Syntax highlighting enabled for languages other than Objective-C#79suranyami wants to merge 7 commits intobrotherbard:experimentalfrom
suranyami wants to merge 7 commits intobrotherbard:experimentalfrom
Conversation
we can use the file suffix to determine which syntax highlighting to use.
… pick the brush for syntax highlighting.
…the one we need for the given file type.
Added a hash of possible values to select the correct brush based on the suffix. This fixes a problem where some suffixes did not match brush aliases.
…h simpler and faster.
|
I've merged yours commits to my master branch, this was on my todo-list ;) |
kelan
pushed a commit
to kelan/gitx
that referenced
this pull request
May 15, 2017
Fixes for stash display
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I've made a few changes that enable syntax highlighting for languages other than Objective-C.
It needed all of the brush javascript files to be imported into:
passing the full file path into
showFilefromGLFileView.mand some javascript string manipulation in
This is based on commit 9dd29f6
I've built and tested it locally using Ruby files and it seemed to work fine. I'm not an expert on Objective-C, though, so don't be surprised if I've not cleaned up a pointer or somesuch.
Also added a Hash of suffix -> brush mappings, so that the right brush will be applied to file type.
Thanks for your fabulous work with GitX, btw. Our team uses it every day, and couldn't live without it.