Sourcery Starbot ⭐ refactored ccombe/practical-python

Solutions/1_10/mortgage.py

@@ -11,16 +11,16 @@
 extra_payment_end_month = 108
 
 while principal > 0:
-    month = month + 1
+    month += 1
     principal = principal * (1+rate/12) - payment
-    total_paid = total_paid + payment
+    total_paid += payment
 
     if month >= extra_payment_start_month and month <= extra_payment_end_month:
-        principal = principal - extra_payment
-        total_paid = total_paid + extra_payment
+        principal -= extra_payment
+        total_paid += extra_payment
 
     print(month, round(total_paid,2), round(principal, 2))
-    
+
 print('Total paid', round(total_paid, 2))
 print('Months', month)
 

Solutions/1_33/pcost.py

@@ -22,10 +22,6 @@ def portfolio_cost(filename):
     return total_cost
 
 import sys
-if len(sys.argv) == 2:
-    filename = sys.argv[1]
-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')
 cost = portfolio_cost(filename)
 print('Total cost:', cost)

Solutions/1_5/bounce.py

@@ -1,8 +1,6 @@
 # bounce.py
 
 height = 100
-bounce = 1
-while bounce <= 10:
-    height = height * (3/5)
+for bounce in range(1, 11):
+    height *= 3/5
     print(bounce, round(height, 4))
-    bounce += 1

Solutions/2_16/pcost.py

@@ -23,10 +23,6 @@ def portfolio_cost(filename):
     return total_cost
 
 import sys
-if len(sys.argv) == 2:
-    filename = sys.argv[1]
-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')
 cost = portfolio_cost(filename)
 print('Total cost:', cost)

Solutions/3_10/fileparse.py

@@ -39,10 +39,7 @@ def parse_csv(filename, select=None, types=None, has_headers=True, delimiter=','
                     continue
 
             # Make a dictionary or a tuple
-            if headers:
-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)
             records.append(record)
 
         return records

Solutions/3_14/fileparse.py

@@ -39,10 +39,7 @@ def parse_csv(filename, select=None, types=None, has_headers=True, delimiter=','
                     continue
 
             # Make a dictionary or a tuple
-            if headers:
-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)
             records.append(record)
 
         return records

Solutions/3_14/pcost.py

@@ -7,13 +7,9 @@ def portfolio_cost(filename):
     Computes the total cost (shares*price) of a portfolio file
     '''
     portfolio = report.read_portfolio(filename)
-    return sum([s['shares']*s['price'] for s in portfolio])
+    return sum(s['shares']*s['price'] for s in portfolio)
 
 import sys
-if len(sys.argv) == 2:
-    filename = sys.argv[1]
-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')
 cost = portfolio_cost(filename)
 print('Total cost:', cost)

Solutions/3_16/fileparse.py

@@ -39,10 +39,7 @@ def parse_csv(filename, select=None, types=None, has_headers=True, delimiter=','
                     continue
 
             # Make a dictionary or a tuple
-            if headers:
-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)
             records.append(record)
 
         return records

Solutions/3_16/pcost.py

@@ -7,7 +7,7 @@ def portfolio_cost(filename):
     Computes the total cost (shares*price) of a portfolio file
     '''
     portfolio = report.read_portfolio(filename)
-    return sum([s['shares'] * s['price'] for s in portfolio])
+    return sum(s['shares'] * s['price'] for s in portfolio)
 
 def main(args):
     if len(args) != 2:

Solutions/3_18/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/3_18/pcost.py

@@ -7,7 +7,7 @@ def portfolio_cost(filename):
     Computes the total cost (shares*price) of a portfolio file
     '''
     portfolio = report.read_portfolio(filename)
-    return sum([s['shares'] * s['price'] for s in portfolio])
+    return sum(s['shares'] * s['price'] for s in portfolio)
 
 def main(args):
     if len(args) != 2:

Solutions/3_7/fileparse.py

@@ -30,10 +30,7 @@ def parse_csv(filename, select=None, types=None, has_headers=True, delimiter=','
                 row = [func(val) for func, val in zip(types, row)]
 
             # Make a dictionary or a tuple
-            if headers:
-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)
             records.append(record)
 
         return records

Solutions/4_10/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/4_10/pcost.py

@@ -7,7 +7,7 @@ def portfolio_cost(filename):
     Computes the total cost (shares*price) of a portfolio file
     '''
     portfolio = report.read_portfolio(filename)
-    return sum([s.cost() for s in portfolio])
+    return sum(s.cost() for s in portfolio)
 
 def main(args):
     if len(args) != 2:

Solutions/4_10/report.py

@@ -14,8 +14,7 @@ def read_portfolio(filename):
                                         select=['name','shares','price'], 
                                         types=[str,int,float])
 
-    portfolio = [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
-    return portfolio
+    return [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
 
 def read_prices(filename):
     '''

Solutions/4_4/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/4_4/pcost.py

@@ -7,7 +7,7 @@ def portfolio_cost(filename):
     Computes the total cost (shares*price) of a portfolio file
     '''
     portfolio = report.read_portfolio(filename)
-    return sum([s.cost() for s in portfolio])
+    return sum(s.cost() for s in portfolio)
 
 def main(args):
     if len(args) != 2:

Solutions/4_4/report.py

@@ -13,8 +13,7 @@ def read_portfolio(filename):
                                         select=['name','shares','price'], 
                                         types=[str,int,float])
 
-    portfolio = [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
-    return portfolio
+    return [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
 
 def read_prices(filename):
     '''

Solutions/5_8/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/5_8/pcost.py

@@ -7,7 +7,7 @@ def portfolio_cost(filename):
     Computes the total cost (shares*price) of a portfolio file
     '''
     portfolio = report.read_portfolio(filename)
-    return sum([s.cost() for s in portfolio])
+    return sum(s.cost() for s in portfolio)
 
 def main(args):
     if len(args) != 2:

Solutions/5_8/report.py

@@ -14,8 +14,7 @@ def read_portfolio(filename):
                                         select=['name','shares','price'], 
                                         types=[str,int,float])
 
-    portfolio = [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
-    return portfolio
+    return [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
 
 def read_prices(filename):
     '''

Solutions/6_12/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/6_12/portfolio.py

@@ -14,11 +14,11 @@ def __getitem__(self, index):
         return self._holdings[index]
 
     def __contains__(self, name):
-        return any([s.name == name for s in self._holdings])
+        return any(s.name == name for s in self._holdings)
 
     @property
     def total_cost(self):
-        return sum([s.shares * s.price for s in self._holdings])
+        return sum(s.shares * s.price for s in self._holdings)
 
     def tabulate_shares(self):
         from collections import Counter

Solutions/6_15/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/6_3/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/6_3/portfolio.py

@@ -14,11 +14,11 @@ def __getitem__(self, index):
         return self._holdings[index]
 
     def __contains__(self, name):
-        return any([s.name == name for s in self._holdings])
+        return any(s.name == name for s in self._holdings)
 
     @property
     def total_cost(self):
-        return sum([s.shares * s.price for s in self._holdings])
+        return sum(s.shares * s.price for s in self._holdings)
 
     def tabulate_shares(self):
         from collections import Counter

Solutions/6_7/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/6_7/portfolio.py

@@ -14,11 +14,11 @@ def __getitem__(self, index):
         return self._holdings[index]
 
     def __contains__(self, name):
-        return any([s.name == name for s in self._holdings])
+        return any(s.name == name for s in self._holdings)
 
     @property
     def total_cost(self):
-        return sum([s.shares * s.price for s in self._holdings])
+        return sum(s.shares * s.price for s in self._holdings)
 
     def tabulate_shares(self):
         from collections import Counter

Solutions/7_11/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/7_4/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/7_9/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/8_1/fileparse.py

@@ -38,10 +38,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records

Solutions/8_2/fileparse.py

@@ -40,10 +40,7 @@ def parse_csv(lines, select=None, types=None, has_headers=True, delimiter=',', s
                 continue
 
         # Make a dictionary or a tuple
-        if headers:
-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)
         records.append(record)
 
     return records