docs: add popkins (sepolia + celestia mocha) and local OP Stack & Nitro devnet guides#2395
docs: add popkins (sepolia + celestia mocha) and local OP Stack & Nitro devnet guides#2395
Conversation
Add guide for spinning up a complete local OP Stack rollup with Celestia DA using pop-deployer. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation by introducing a new guide for setting up a local OP Stack development environment integrated with Celestia Data Availability. It also reorganizes existing Optimism-related documentation for better clarity and navigation, alongside standard dependency updates to maintain project health. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🚀 Preview Deployment Your preview is ready: https://celestiaorg.github.io/docs-preview/pr-2395/ |
There was a problem hiding this comment.
Code Review
This pull request adds comprehensive documentation for setting up an OP Stack devnet, both locally and with external services like Popkins. The changes are well-structured and add significant value. However, the new popkins-popsigner guide contains several critical security issues related to hardcoded secrets and incorrect configuration instructions that must be addressed. I have also included some medium-severity suggestions to improve clarity and fix minor issues.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use relative link for op-alt-da reference - Remove trailing space from batcher address - Change http to https for Popsigner.com link - Clarify namespace format (29 bytes = 58 hex chars) - Fix namespace generation command to produce correct length Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ocal devnet - Document service ports (L1: 8545, L2: 8547, Localestia: 26658) - Clarify that test accounts are only pre-funded on L1 - Add warnings about test keys being public - Explain what each service component does - Note that funds must be bridged from L1 to L2
Summary
pop-deployerto generate pre-deployed bundles that run instantly via DockerTest plan