feat: add device message about legacy mvbox_move

[link2xt]

Closes #7774

[r10s]

i drafted a page with more details at deltachat/deltachat-pages#1254

[Hocuri]

The test fails because the default for MvboxMove is still 1. We should change the default to 0.

Edit: Actually, even though the default is "1" here for compatibility reasons, is disabled in new profiles during configure already. So, we only need to fix the failing Rust test, which should be pretty easy.

[Hocuri]

Device message LGTM once Björn's comment is addressed. (and we need to make CI pass, ofc)

[Hocuri]

Should be called maybe_add_mvbox_move_deprecation_message(), because this is how we usually call functions with a condition inside

[r10s]

i went forward and changed then device message, after discussing with @Hocuri

[r10s]

Actually, even though the default is "1" here for compatibility reasons, is disabled in new profiles during configure already. So, we only need to fix the failing Rust test, which should be pretty easy. So, we only need to fix the failing Rust test, which should be pretty easy.

the failing test is test_reaction_summary. for some reason, it sees the device message where it should not, if MvboxMove is not set for new profiles. maybe a race, running housekeeping before configure() sets the value? EDIT: housekeeping is run by the test itself - not sure, why mvbox_move is 1 there, when it is set to 0 during configure()

EDIT: if you change the last lines of the test to ...

        assert!(alice.is_configured().await?);
        assert_eq!(alice.get_config(Config::MvboxMove).await?.unwrap(), "0"); // XXX this fails
        assert_summary(&alice, "kewl").await;

        Ok(())

... the test fails at XXX. so, MvboxMove is actually not set to "0" for that test.

[link2xt]

"move to a dedicated chat profile" sounds wrong, the profile stays the same but you move to a different relay.

[r10s]

the outcome by adding a relay and removing the existing one, however, is a dedicated chat profile. which is needed as a shared chat profile is no longer supported

here, however, maybe we can just strike the suffix, so If having chat messages mixed into your inbox is a problem, see https://delta.chat/legacy-move

[r10s]

ftr, this is how it looks like: