fix(ui): add clerk dependency to redirect useEffect hooks #7529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes redirect conflicts when SignIn and SignUp components are used together on the same page.
Problem
When both
<SignIn />and<SignUp />components are rendered on the same page, they interfere with each other's navigation flows, causing unexpected redirects to the Clerk domain.Root Cause
The
RedirectToSignInandRedirectToSignUpcomponents had incomplete dependency arrays in their useEffect hooks:This violates React's exhaustive-deps rule and can cause unpredictable behavior.
Solution
Added
clerkto the dependency arrays:Changes
RedirectToSignInin packages/ui/src/components/SignIn/index.tsxRedirectToSignUpin packages/ui/src/components/SignUp/index.tsxNotes
Related to issue #7456
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.