fix(windows): add missing RawStream::Virtual match arm in `AsRawSoc…#809
Open
soddygo wants to merge 1 commit intocloudflare:mainfrom
Open
fix(windows): add missing RawStream::Virtual match arm in `AsRawSoc…#809soddygo wants to merge 1 commit intocloudflare:mainfrom
RawStream::Virtual match arm in `AsRawSoc…#809soddygo wants to merge 1 commit intocloudflare:mainfrom
Conversation
…ket` impl The `#[cfg(windows)] impl AsRawSocket for RawStream` was missing a match arm for the `RawStream::Virtual(_)` variant, causing a compilation error (E0004: non-exhaustive patterns) on Windows targets. The `Virtual` variant is not gated by any `#[cfg]` attribute and exists on all platforms, but the Windows `AsRawSocket` implementation only matched `RawStream::Tcp(s)`. This fix adds the missing arm, returning `!0` (INVALID_SOCKET) for virtual streams, consistent with the Unix `AsRawFd` implementation which returns `-1` for the same variant. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
#[cfg(windows)] impl AsRawSocket for RawStreaminpingora-core/src/protocols/l4/stream.rsis missing a match arm for theRawStream::Virtual(_)variant, causing a compilation error (E0004: non-exhaustive patterns) on Windows targets.The
Virtualvariant is defined without any#[cfg]gate and exists on all platforms. The Unix counterpart (AsRawFd for RawStream) already correctly handles this variant by returning-1.Fix
Added the missing match arm returning
!0(INVALID_SOCKET) for virtual streams, consistent with the Unix implementation:RawStream::Virtual(_) => -1RawStream::Virtual(_) => !0Verification
#[cfg(windows)]match onRawStreammissing theVirtualarmstream.rs(AsyncRead, AsyncWrite, Drop, etc.) already handleVirtualcorrectly