Add recreate-vms-created-before option to recreate and deploy commands #710

Alphasite · 2026-01-28T22:46:57Z

CLI counterpart to cloudfoundry/bosh#2656

The goal is to allow resumption of failed bosh repave (recreate) from where it failed, speeding up repave operations.

CLI counterpart to !2656 The goal is to allow resumption of failed bosh repave (recreate) from where it failed, speeding up repave operations.

cmd/opts/opts.go

Alphasite · 2026-01-30T04:03:26Z

See other pr for manual testing

Replace opaque string types with proper time.Time for the recreate-vms-created-before and vms-created-before flags. This provides type safety, validation at parse time, and clearer error messages for invalid RFC 3339 timestamps. - Add TimeArg type with UnmarshalFlag for parsing RFC 3339 timestamps - Update DeployOpts and RecreateOpts to use TimeArg - Update director UpdateOpts and RecreateOpts to use time.Time - Add comprehensive tests for TimeArg parsing and formatting

selzoc · 2026-02-02T23:01:01Z

cmd/opts/opts.go

-	SkipUploadReleases      bool                `long:"skip-upload-releases"                  description:"Skips the upload procedure for releases"`
+	Recreate                 bool                `long:"recreate"                                description:"Recreate all VMs in deployment"`
+	RecreatePersistentDisks  bool                `long:"recreate-persistent-disks"               description:"Recreate all persistent disks in deployment"`
+	RecreateVMsCreatedBefore TimeArg             `long:"recreate-vms-created-before"             description:"Only recreate VMs created before the given RFC 3339 timestamp (requires --recreate)"`


What time zone are we enforcing here?

I believe RFC3339 requires a timezone be specified in the timezone string: https://datatracker.ietf.org/doc/html/rfc3339#section-5.6 and UTC is the preferred format. I dont feel strongly, but i was inclined to just allow what ever timezones the spec allows (Z +/- an offset from UTC)

ill add tests to make sure it behaves the way we expect; based on yours an arams feedback.

make sure it handles dates without a +00:00

make sure all timestamps are UTC timezone internally

…timezone offset

Copilot

Pull request overview

Adds a timestamp-based filter to recreate and deploy --recreate so operators can resume a failed repave by only recreating VMs created before a given point in time.

Changes:

Extend director RecreateOpts/UpdateOpts to carry a VMsCreatedBefore/RecreateVMsCreatedBefore timestamp and send it as recreate_vm_created_before in requests.
Add CLI flags for deploy (--recreate-vms-created-before) and recreate (--vms-created-before) and wire them through to director calls.
Introduce TimeArg flag type with parsing + tests, and add request/CLI tests covering the new query parameter.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
director/interfaces.go	Adds timestamp fields to recreate/update option structs.
director/deployment.go	Plumbs timestamp into ChangeJobState/UpdateDeployment query params.
director/deployment_test.go	Adds tests asserting the new query param is sent.
cmd/recreate.go	Wires new recreate timestamp option into director recreate opts.
cmd/recreate_test.go	Tests that recreate passes the timestamp through.
cmd/deploy.go	Wires new deploy recreate timestamp option into director update opts.
cmd/deploy_test.go	Tests that deploy passes the timestamp through.
cmd/opts/time_arg.go	New flag type for parsing RFC3339(-like) timestamps.
cmd/opts/time_arg_test.go	Unit tests for TimeArg parsing/formatting behavior.
cmd/opts/opts.go	Adds CLI flags for the new timestamp filters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T00:00:19Z

cmd/deploy.go

 	updateOpts := boshdir.UpdateOpts{
-		RecreatePersistentDisks: opts.RecreatePersistentDisks,
-		Recreate:                opts.Recreate,
-		Fix:                     opts.Fix,
-		SkipDrain:               opts.SkipDrain,
-		DryRun:                  opts.DryRun,
-		Canaries:                opts.Canaries,
-		MaxInFlight:             opts.MaxInFlight,
-		Diff:                    deploymentDiff,
-		ForceLatestVariables:    opts.ForceLatestVariables,
+		RecreatePersistentDisks:  opts.RecreatePersistentDisks,
+		Recreate:                 opts.Recreate,
+		RecreateVMsCreatedBefore: opts.RecreateVMsCreatedBefore.Time,
+		Fix:                      opts.Fix,


DeployCmd always passes RecreateVMsCreatedBefore through to the director when the flag is set, but there’s no validation that --recreate was also provided (even though the flag description says it’s required). Add a check to error (or automatically imply Recreate=true) when a timestamp is provided without opts.Recreate, otherwise the director may reject/ignore the parameter.

Copilot · 2026-02-04T00:00:19Z

cmd/recreate.go

+			Canaries:         opts.Canaries,
+			MaxInFlight:      opts.MaxInFlight,
+			Converge:         true,
+			VMsCreatedBefore: opts.VMsCreatedBefore.Time,
 		}


--vms-created-before is only applied in the converge branch. If a user runs recreate with --no-converge and provides this flag, it will be silently ignored. Consider validating and returning an error when VMsCreatedBefore is set together with --no-converge (or otherwise document/handle the behavior explicitly).

Copilot · 2026-02-04T00:00:19Z

cmd/opts/time_arg.go

+	t, err := time.Parse(time.RFC3339, data)
+	if err != nil {
+		// Try RFC3339 without timezone suffix, assume UTC
+		// Format: "2006-01-02T15:04:05"
+		t, err = time.Parse("2006-01-02T15:04:05", data)


UnmarshalFlag uses time.Parse(time.RFC3339, ...), which rejects valid RFC 3339 timestamps that include fractional seconds (e.g. 2026-01-01T00:00:00.123Z). If the flag is documented as “RFC 3339”, consider trying time.RFC3339Nano (or accepting both) so users can paste timestamps produced by common tooling.

Copilot · 2026-02-04T00:00:19Z

cmd/opts/time_arg.go

+func (a TimeArg) AsString() string {
+	if a.IsSet() {
+		// Always output in UTC with Z suffix for consistency
+		return a.Format(time.RFC3339)


AsString’s comment says it always outputs UTC with a Z suffix, but it calls a.Format(time.RFC3339) directly. If TimeArg is constructed programmatically with a non-UTC location, this will output an offset instead of Z. Consider formatting a.UTC() (or enforcing UTC on assignment) to match the documented behavior.

Suggested change

return a.Format(time.RFC3339)

return a.UTC().Format(time.RFC3339)

Add recreate-vms-created-before option to recreate and deploy commands

67f5095

CLI counterpart to !2656 The goal is to allow resumption of failed bosh repave (recreate) from where it failed, speeding up repave operations.

cf-foundation-community-automation bot added this to Foundational Infrastructure Working Group Jan 28, 2026

cf-foundation-community-automation bot moved this to Inbox in Foundational Infrastructure Working Group Jan 28, 2026

Alphasite requested review from aramprice and selzoc January 29, 2026 01:08

Alphasite self-assigned this Jan 29, 2026

Alphasite added the planned-enhancement label Jan 29, 2026

aramprice reviewed Jan 29, 2026

View reviewed changes

cmd/opts/opts.go Outdated Show resolved Hide resolved

Alphasite requested a review from aramprice January 29, 2026 19:56

Alphasite marked this pull request as ready for review January 30, 2026 04:03

Alphasite force-pushed the recreate-vms-timestamp branch from df07972 to 8cd5366 Compare January 30, 2026 04:23

aramprice previously approved these changes Feb 2, 2026

View reviewed changes

github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Feb 2, 2026

selzoc reviewed Feb 2, 2026

View reviewed changes

Address review comments and allow cli to handle timestamps without a …

d4b8311

…timezone offset

Copilot AI review requested due to automatic review settings February 3, 2026 23:55

Alphasite dismissed aramprice’s stale review via d4b8311 February 3, 2026 23:55

Copilot started reviewing on behalf of Alphasite February 3, 2026 23:55 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

beyhan moved this from Pending Merge | Prioritized to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Feb 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recreate-vms-created-before option to recreate and deploy commands #710

Add recreate-vms-created-before option to recreate and deploy commands #710

Uh oh!

Alphasite commented Jan 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Alphasite commented Jan 30, 2026

Uh oh!

selzoc Feb 2, 2026

Uh oh!

Alphasite Feb 3, 2026 •

edited

Loading

Uh oh!

Alphasite Feb 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	return a.Format(time.RFC3339)
	return a.UTC().Format(time.RFC3339)

Add recreate-vms-created-before option to recreate and deploy commands #710

Are you sure you want to change the base?

Add recreate-vms-created-before option to recreate and deploy commands #710

Uh oh!

Conversation

Alphasite commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Alphasite commented Jan 30, 2026

Uh oh!

selzoc Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Alphasite Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alphasite Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alphasite commented Jan 28, 2026 •

edited

Loading

Alphasite Feb 3, 2026 •

edited

Loading