GardenerNodeLifecycle: Base it on the Hypervisor CRD, do not label node#184
Open
GardenerNodeLifecycle: Base it on the Hypervisor CRD, do not label node#184
Conversation
fwiesel
force-pushed
the
gardener-node-lifecycle-hv
branch
2 times, most recently
from
3604ae9 to
6fd924c
Compare
Contributor
Author
|
This assumes the maintenance-operator is deployed and sets the maintenance flag. |
The eviction will now be triggered by the maintenance-operator, so drop setting the label. Watch the conditions on the hypervisor and manage the pods / deployments in kube-system to signal gardener that - the node is ready when the onboarding condition is completed - the node can be drained (and therefor terminated) if it has been evicted
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
notandy
approved these changes
Nov 20, 2025
|
This PR is stale because it has been open for 45 days with no activity. |
|
This PR was closed because it has been inactive for 14 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eviction will now be triggered by the maintenance-operator, so drop setting the label.
Watch the conditions on the hypervisor and manage the pods / deployments in kube-system to signal gardener that