Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Jan 26, 2026

  • Block gardener with pdb until offboarded
  • Communicate offboarded via condition on hypervisor
  • Do only decomissioning via hypervisor cro

Use offboarded instead of decomissioning as it
is clearer the opposite from onboarding.

@fwiesel fwiesel requested a review from notandy January 26, 2026 14:30
@fwiesel fwiesel force-pushed the offboarding-hypervisor branch from 4d6caf2 to 36f897c Compare January 27, 2026 10:11
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 55.51% (-0.18%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller.go 54.69% (-3.75%) 64 (-13) 35 (-10) 29 (-3) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller.go 64.29% (+3.57%) 56 36 (+2) 20 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller_test.go

- Block gardener with pdb until offboarded
- Communicate offboarded via condition on hypervisor
- Do only decomissioning via hypervisor cro

Use offboarded instead of decomissioning as it
is clearer the opposite from onboarding.
Copy link
Contributor

@notandy notandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, I also like to use Positive = True Conditions - having Conditions only false if they signal a transient state.

@fwiesel fwiesel merged commit 21a6831 into main Jan 28, 2026
6 checks passed
@fwiesel fwiesel deleted the offboarding-hypervisor branch January 28, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants