Fix SpotBugs findings (comparisons, toString, equals/hashCode, iterators, oddness, float loops) and enforce rules

[shai-almog]

Motivation

• Address multiple SpotBugs warnings across the codebase to remove fragile patterns and ensure correct semantics for edge cases.
• Make a set of previously tolerated SpotBugs rules fail the quality check so regressions are caught by CI.
• Keep the behavior and public APIs unchanged while removing unsafe or vacuous checks and improving correctness of equality/iteration contracts.

Description

• Remove vacuous/incorrect integer underflow clamps in rectangle intersection helpers in CodenameOne/src/com/codename1/ui/geom/Rectangle.java so intersection math relies on meaningful bounds instead of impossible Integer.MIN_VALUE adjustments.
• Avoid unnecessary toString() calls on String instances and make header keys/values non-null by using casts and Objects.requireNonNull in CodenameOne/src/com/codename1/io/MultipartRequest.java and CodenameOne/src/com/codename1/io/rest/RequestBuilder.java.
• Strengthen object contracts by implementing proper hashCode/equals for PropertyXMLElement and UnitValue, and make iterators throw NoSuchElementException when exhausted in CodenameOne/src/com/codename1/properties/PropertyXMLElement.java and CodenameOne/src/com/codename1/properties/PropertyIndex.java.
• Replace fragile oddness and float-loop patterns with safe integer/bitwise checks and integer loop counters in CodenameOne/src/com/codename1/ui/layouts/mig/ConstraintParser.java, CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java, CodenameOne/src/com/codename1/charts/views/PieSegment.java, and CodenameOne/src/com/codename1/charts/views/RadarChart.java.
• Add SpotBugs rule IDs (INT_VACUOUS_COMPARISON, DM_STRING_TOSTRING, HE_HASHCODE_USE_OBJECT_EQUALS, IM_BAD_CHECK_FOR_ODD, IT_NO_SUCH_ELEMENT, FL_FLOATS_AS_LOOP_COUNTERS) to the forbidden list in .github/scripts/generate-quality-report.py so these findings will fail the build.

Testing

• No automated tests were executed as part of this change (no unit/integration/SpotBugs runs were performed in this rollout).

---

Codex Task

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2282 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.83% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• ❌ SpotBugs: 47 findings (Normal: 37, Low: 10) [HTML preview] [Download]
  • Top findings
    • Normal: CodenameOne/src/com/codename1/capture/Capture.java:262 – Naked notify in com.codename1.capture.Capture$CallBack.actionPerformed(ActionEvent) (rule: NN_NAKED_NOTIFY)
    • Normal: CodenameOne/src/com/codename1/components/WebBrowser.java:159 – Naked notify in com.codename1.components.WebBrowser$4$1.readResponse(InputStream) (rule: NN_NAKED_NOTIFY)
    • Normal: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:246 – Null passed for non-null parameter of java.util.Hashtable.put(Object, Object) in com.codename1.facebook.FacebookRESTService.keyValue(String, String) (rule: NP_NULL_PARAM_DEREF)
    • Normal: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:7184 – Naked notify in com.codename1.impl.CodenameOneImplementation.setPollingFrequency(int) (rule: NN_NAKED_NOTIFY)
    • Normal: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:152 – com.codename1.impl.CodenameOneThread.getStack(Throwable) may fail to close stream (rule: OS_OPEN_STREAM)
    • …and 42 more
• ❌ PMD: 2550 findings (P2: 1, P3: 480, P4: 2069) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1040 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/components/RSSReader.java:500 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/Album.java:198 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:1312 – Unnecessary semicolon (rule: UnnecessarySemicolon)
    • …and 2545 more
• ❌ Checkstyle: 220917 findings (Warning: 220917) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 220912 more

Generated automatically by the PR CI workflow.

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 382 seconds
• Compilation Time: 132 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	31929 ms
Extract Extensions	26 ms
Google Services Setup	1 ms
Scan Classes	1298 ms
Extract Libs	854 ms
Inject Build Hints	56 ms
Generate Unit Tests	3 ms
Generate Stubs	1246 ms
Compile Stubs	2663 ms
Generate Icons	1221 ms
Prepare ParparVM	209 ms
ParparVM Execution	225200 ms
Post-VM Setup	192 ms
CocoaPods	5759 ms
Finalize	31 ms
Total Time	270689 msMaven Overhead : 112000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	66000 ms
App Install	20000 ms
App Launch	6000 ms
Test Execution	149000 ms