Update instructions for contributors #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced a few issues after going through the instructions in
CONTRIBUTING.md. The PR addresses the following issues:make run-seed-codesourcesrequires a valid Github Access Token to be able to access GitHub data, so it should be added to.envfile. I added this information to theCONTRIBUTING.mdfile. Also, I converted it to a numbered list to make it clear that obtaining the token is a separate step.make run-seed-codesourceswill fail even with the valid token, because when the postgres is started nospeedtyperdatabase was created. Fixed it in docker-compose.yml.