Add image_tokens field to ApiMetaBilledUnits#714
Open
yurekami wants to merge 1 commit intocohere-ai:mainfrom
Open
Add image_tokens field to ApiMetaBilledUnits#714yurekami wants to merge 1 commit intocohere-ai:mainfrom
yurekami wants to merge 1 commit intocohere-ai:mainfrom
Conversation
The embedding API returns an `image_tokens` field in the billed_units response that was not present in the model definition. This caused the field to only be accessible through extra attributes. Changes: - Added `image_tokens` field to `ApiMetaBilledUnits` model - Updated `merge_meta_field` utility to properly merge image_tokens - Added tests for image_tokens field and merging Fixes cohere-ai#711 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image_tokensfield to theApiMetaBilledUnitsmodelmerge_meta_fieldutility to properly mergeimage_tokensacross responsesProblem
The embedding API returns an
image_tokensfield in thebilled_unitsresponse, but theApiMetaBilledUnitsmodel only defined animagesfield. This mismatch causedimage_tokensto only be accessible through Pydantic'sextraattributes, leading to confusion and type-checking issues.Example from the issue:
Solution
Added the
image_tokensfield toApiMetaBilledUnits:Also updated
merge_meta_fieldinutils.pyto properly sumimage_tokenswhen merging embed responses.Test plan
test_image_tokens_field- verifies field can be set, accessed, and serializedtest_merge_with_image_tokens- verifies image_tokens are properly mergedNote
The file notes it's "auto-generated by Fern from our API Definition". The API definition may also need to be updated to include this field for future regeneration.
Fixes #711
🤖 Generated with Claude Code