Skip to content

Conversation

@jmg-duarte
Copy link
Contributor

Description

Removes the ethcontract-generate dependency from contracts, along with #4024 we'll be able to fully remove the ethcontract dependency from contracts.

Note that the artifacts JSON changes are outputs from the new vendoring — i.e. the only change was the newline.

Changes

  • Replaces the ethcontract-generate dependency with reqwest and a bit of serde_json work

How to test

  • Checkout the previous contracts
  • Run RUST_BACKTRACE=1 cargo r -p contracts -F bin --bin vendor
  • Validate the diff

@jmg-duarte jmg-duarte requested a review from a team as a code owner January 6, 2026 14:10
@gemini-code-assist
Copy link

Note

The number of changes in this pull request is too large for Gemini Code Assist to generate a summary.

@jmg-duarte
Copy link
Contributor Author

/gemini review

@gemini-code-assist
Copy link

Note

The number of changes in this pull request is too large for Gemini Code Assist to generate a review.

Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@jmg-duarte jmg-duarte enabled auto-merge January 6, 2026 17:03
@jmg-duarte jmg-duarte added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 4449d1f Jan 6, 2026
19 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/alloy/vendoring branch January 6, 2026 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants