Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@waralexrom waralexrom requested a review from a team as a code owner December 18, 2025 12:42
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.14%. Comparing base (d2b6838) to head (88c73bd).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...bejs-schema-compiler/src/adapter/CubeStoreQuery.ts 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d2b6838) and HEAD (88c73bd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d2b6838) HEAD (88c73bd)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10268       +/-   ##
===========================================
- Coverage   83.28%   55.14%   -28.15%     
===========================================
  Files         248      221       -27     
  Lines       74447    17178    -57269     
  Branches        0     3512     +3512     
===========================================
- Hits        62000     9472    -52528     
+ Misses      12447     7213     -5234     
- Partials        0      493      +493     
Flag Coverage Δ
cube-backend 55.14% <0.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@waralexrom waralexrom requested a review from a team as a code owner December 18, 2025 15:32
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@waralexrom waralexrom merged commit cd618e1 into master Dec 18, 2025
168 of 173 checks passed
@waralexrom waralexrom deleted the cubestore-enable-rolling-window-flag branch December 18, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants