fix minor grammar and embolden the golden rule#59
Open
himangSharatun wants to merge 1 commit intocxxr:masterfrom
himangSharatun:master
Open
fix minor grammar and embolden the golden rule#59himangSharatun wants to merge 1 commit intocxxr:masterfrom himangSharatun:master
himangSharatun wants to merge 1 commit intocxxr:masterfrom
himangSharatun:master
Conversation
cxxr
requested changes
Oct 27, 2017
Owner
cxxr
left a comment
cxxr
left a comment
There was a problem hiding this comment.
I dislike the changes to making things capitalized like CAUTION. If you revert those I'll look again. Thanks!
| own. Better is to make your exceptions extend RuntimeException instead. This | ||
| allows your users to handle your exceptions in the way they would like, rather | ||
| than forcing them to handle/declare that it throws every time, which pollutes | ||
| [Checked exceptions][checkedex] should be used with CAUTION, if at all. They |
| Try to avoid using nulls when you can. Do not return null collections when you | ||
| should have instead returned an empty collection. If you're going to use null, | ||
| consider the [@Nullable][nullable] annotation. [IntelliJ IDEA][intellij] has | ||
| Try to avoid using null when you can. DO NOT return null collections when you |
| So now it's clear that *data* will never be null, but *bar* may or may not be | ||
| present. *Optional* has methods like *isPresent*, which may make it feel like | ||
| not a lot is different from just checking *null*. But it allows you to write | ||
| present. *Optional* has methods like *isPresent*, which make it seems similar with just checking *null*. But it allows you to write |
Author
|
okay i will fix it but i will create another pull request after i finish translating it to indonesia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i want to translate this guide into Bahasa Indonesi but i don't have time yet.