CM-55207: Fix Secrets documents collecting for diff scan #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sterczewski
requested review from
elsapet and
gotbadger
as code owners
gotbadger
approved these changes
Jan 7, 2026
gotbadger
changed the title
mateusz-sterczewski
deleted the
CM-55207-Fix-documents-collecting-for-secrets-commit-range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifying the git diff collecting between SCA/SAST and now Secrets.
Previously we've been using
repo.iter_commits(...), which seems to not have been working.The case we see from the bug report is as follows
A~1...A, which should now be working and should be covered by test.