Type widening for accepted records #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodordelibasic-db
requested review from
elenagaljak-db
and removed request for
elenagaljak-db
elenagaljak-db
previously approved these changes
Dec 1, 2025
Collaborator
elenagaljak-db
left a comment
elenagaljak-db
left a comment
There was a problem hiding this comment.
Lgtm, although I am starting to second guess the decision of sending JSON records as dictionaries
Signed-off-by: teodordelibasic-db <[email protected]>
teodordelibasic-db
force-pushed
the
fix-json-examples
branch
from
23e7c2e to
b457476
Compare
teodordelibasic-db
changed the title
danilonajkov-db
previously approved these changes
Dec 22, 2025
| offset1 = await ack1 | ||
| self.assertEqual(offset1, 0) | ||
|
|
||
| ack2 = await stream.ingest_record(json.dumps({"device_name": "device2", "temp": 22, "humidity": 55})) |
There was a problem hiding this comment.
It would be good to add tests for every value type we support
Collaborator
Author
There was a problem hiding this comment.
Done, thanks.
zerobus/sdk/aio/zerobus_sdk.py
Outdated
| elif self._options.record_type == RecordType.JSON: | ||
| if not isinstance(record, dict): | ||
| if isinstance(record, dict): | ||
| serialized_record = json.dumps(record).encode("utf-8") |
There was a problem hiding this comment.
Should we try catch json dumps? Example if user provides nested custom classes etc, this will raise an exception. Maybe we want to wrap it into our error handling.
Collaborator
Author
There was a problem hiding this comment.
Done, thanks.
Signed-off-by: teodordelibasic-db <[email protected]>
Signed-off-by: teodordelibasic-db <[email protected]>
elenagaljak-db
approved these changes
Dec 29, 2025
danilonajkov-db
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Introduce type widening for the type of records the
ingest_recordmethod accepts to dict/string for JSON and Message/bytes for Protobuf.How is this tested?
New tests, manual and examples.