Add M5 iPad Pro models #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zandor300
requested changes
Nov 9, 2025
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Copilot
AI
changed the title
[WIP] Add M5 iPad models to DeviceKit
Add M5 iPad Pro models
Nov 9, 2025
Member
|
@copilot Please remove all sourceLocation comments inside the generated Swift file. |
Contributor
Author
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds support for the new M5 iPad Pro models announced by Apple on October 15, 2025. The implementation follows the established pattern for adding new device support to DeviceKit.
Key Changes:
- Added M5 CPU definition to the device library
- Added two new M5 iPad Pro device models (11-inch and 13-inch) with their respective model identifiers
- Added comprehensive test coverage for the new devices and CPU type
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Source/Device.swift.gyb | Template file updated with M5 CPU definition and two M5 iPad Pro device entries (iPad17,3/4 for 11-inch and iPad17,5/6 for 13-inch) |
| Source/Device.generated.swift | Generated Swift code from template including new device cases, model mappings, CPU definitions, and device array updates across all relevant collections |
| Tests/Tests.swift | Added comprehensive test assertions covering CPU type, Pro device classification, 5G support, LiDAR sensor, and USB-C connectivity for both M5 iPad Pro models |
| CHANGELOG.md | Added unreleased section documenting the October 2025 M5 iPad Pro additions with device names and case values |
Member
|
@copilot Rebase on master and add a changelog entry under existing unreleased. Example: |
Contributor
Author
... Fixed in commit 952d5d0. Updated CHANGELOG.md to follow the format from master with the existing "Bug fixes" section preserved and M5 iPad Pro entries added under "New devices" section with issue link (#465). |
Co-authored-by: Zandor300 <[email protected]> # Conflicts: # CHANGELOG.md # Source/Device.generated.swift
Co-authored-by: Zandor300 <[email protected]>
Zandor300
force-pushed
the
copilot/add-m5-ipad-models
branch
from
952d5d0 to
04479e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan: Add M5 iPad Pro Models ✅
Based on the issue requirements and exploration, here's the minimal-change plan:
Summary
Successfully added support for M5 iPad Pro models announced by Apple on October 15, 2025:
Changes Made:
--line-directive ''flag and2>/dev/nullto remove sourceLocation comments and Python warningsDevice Details:
Verification:
✅ Device cases properly defined
✅ Model identifiers correctly mapped
✅ M5 CPU definition added
✅ Included in allProDevices array
✅ 10 test assertions added
✅ Changelog updated with proper format matching master
✅ Python warnings removed from generated file
✅ All generated code validated
✅ No security issues detected
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.