Skip to content

Conversation

@davidlehn
Copy link
Member

  • Update for undici@6 security issue.
  • Update eslint.
  • General updates.

Further research and testing needed to see if an update to undici@7 is a breaking change or not.

- `eslint@9`.
- `eslint-config-digitalbazaar` to `@digitalbazaar/eslint-config@7`.
-  Fix lint issues.
- Update dev dependencies.
- Update test dependencies.
@davidlehn davidlehn requested a review from dlongley January 15, 2026 02:23
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.06%. Comparing base (d7f049c) to head (db8ff8e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   94.09%   94.06%   -0.03%     
==========================================
  Files           4        4              
  Lines         237      236       -1     
==========================================
- Hits          223      222       -1     
  Misses         14       14              
Files with missing lines Coverage Δ
lib/agentCompatibility.js 92.30% <ø> (-0.15%) ⬇️
lib/deferred.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f049c...db8ff8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

timeout-minutes: 10
strategy:
matrix:
node-version: [18.x, 20.x, 22.x, 24.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18 is EOL so we don't need to test against it.

Suggested change
node-version: [18.x, 20.x, 22.x, 24.x]
node-version: [20.x, 22.x, 24.x]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. I was leaving it at 18.x since the only support issue is the trivial testing need to use chai@4 vs 5+. I thought it would be good to be a bit more conservative in this case since this library might have wider use than many of our others in part due to the use in jsonld.js, which still supports 18.x. An undici@7 update would force the issue, so I thought it would be fine to wait until that change is tested to drop old version testing.

@davidlehn davidlehn merged commit dc82c1d into main Jan 15, 2026
13 checks passed
@davidlehn davidlehn deleted the update-deps branch January 15, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants