Warn when pipeline meta-steps execute with no child steps #13648
+157
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When users run
aspire deploywithout deployment resources configured, the command reports success despite doing nothing. This leaves users uncertain whether deployment succeeded or configuration is missing.Changes
Added
CheckForEmptyMetaSteptoDistributedApplicationPipeline.ExecuteAsync:--stepflagWarning output:
Example scenario triggering warning:
Testing
Checklist
Original prompt
This section details on the original issue you should resolve
<issue_title>
aspire deploydoesn't report failure when nothing was deployed</issue_title><issue_description>### Is there an existing issue for this?
Describe the bug
I tried to run the
aspire deploycommand with the expectation that it would tell me what's missing for my app to be deployed, instead it reported success.Nothing was deployed.
> aspire deploy 12:52:11 (pipeline execution) → Starting pipeline execution... 12:52:11 (deploy) → Starting deploy... 12:52:11 (deploy) ✓ deploy completed successfully 12:52:11 (pipeline execution) ✓ Completed successfully ------------------------------------------------------------ ✓ 2/2 steps succeeded • Total time: 0.0s Steps Summary: 0.0 s ✓ pipeline execution 0.0 s ✓ deploy ✓ PIPELINE SUCCEEDEDExpected Behavior
An error or a warning that cloud resources are missing
Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version info
Anything else?
No response</issue_description>
<agent_instructions>Add logic to the distributed application pipeline that will check to see if any child steps will run as part of the meta-steps that are registered in the pipeline. If no child steps will run, then emit a log message indicating that no steps have been found. Do this only when the step that was invoked is empty.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
@captainsafia @tonybaloney Thanks for reporting this issue!We had a failure mode that would tell you what you needed to do (add a compute environment to your AppHost) but we lost this ability as par...
aspire deploydoesn't report failure when nothing was deployed #13602✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.