-
-
Notifications
You must be signed in to change notification settings - Fork 373
chore(LLMs): add output parameter for tools #7479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The PR title/description mention LLM output parameters, but the diff only updates dotnet-tools.json and Directory.Build.targets for BootstrapBlazor.Server; please align the title/description with the actual changes or update the implementation accordingly.
- For the changes in dotnet-tools.json and Directory.Build.targets, it would help to briefly describe why these specific tool and build target adjustments are needed and what behavior they are intended to change for BootstrapBlazor.Server.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title/description mention LLM output parameters, but the diff only updates dotnet-tools.json and Directory.Build.targets for BootstrapBlazor.Server; please align the title/description with the actual changes or update the implementation accordingly.
- For the changes in dotnet-tools.json and Directory.Build.targets, it would help to briefly describe why these specific tool and build target adjustments are needed and what behavior they are intended to change for BootstrapBlazor.Server.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the LLMs documentation generator tool configuration to add an output parameter that specifies where documentation should be generated. The changes coordinate a tool version upgrade with updated build target configuration.
- Updates the
bootstrapblazor.llmsdocsgeneratortool from version 10.0.1 to 10.0.2 - Adds
--output=$(PublishDir)parameter to the llms-docs command to control output location - Changes the build target timing from
AfterPublishtoPublish
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Directory.Build.targets | Modified MSBuild target to add output parameter and change execution timing for LLMs documentation generation |
| dotnet-tools.json | Updated bootstrapblazor.llmsdocsgenerator tool version from 10.0.1 to 10.0.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7479 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 32936 32936
Branches 4576 4576
=========================================
Hits 32936 32936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7478
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update tooling and build configuration for the BootstrapBlazor.Server project.
Build: