-
Notifications
You must be signed in to change notification settings - Fork 4
debugui: add Dropdown #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to show the current issue in a better way
hajimehoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a dropdown to example/gallery
|
I have made the changes, removed the Dropdown type, renamed that variable and put one example of the dropdown into the gallery, into a window |
hajimehoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems generally good.
Removed some obvious comments, keeping only the specific ones about the dropdowns removed isOpen variable that was used only once
|
I corrected wrong licence Now the code seems pretty clean |
hajimehoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry I've not approved yet)
hajimehoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Implemented a dropdown menu for debugui.
It allows listing selectable items, but there's still an issue: widgets behind the dropdown remain interactable, even when the dropdown is open and overlapping them.
Usage is just like the other widgets