Skip to content

Conversation

@Vmarcelo49
Copy link
Contributor

Implemented a dropdown menu for debugui.

It allows listing selectable items, but there's still an issue: widgets behind the dropdown remain interactable, even when the dropdown is open and overlapping them.

Usage is just like the other widgets

ctx.Dropdown(&pointerToIndex, sliceOfStrings).On(func() {
					doSomething())
				})

@hajimehoshi hajimehoshi marked this pull request as draft June 29, 2025 04:03
@hajimehoshi hajimehoshi marked this pull request as ready for review July 2, 2025 13:26
Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a dropdown to example/gallery

@Vmarcelo49
Copy link
Contributor Author

I have made the changes, removed the Dropdown type, renamed that variable and put one example of the dropdown into the gallery, into a window

@hajimehoshi hajimehoshi changed the title WIP Dropdown menu debugui: add Dropdown Jul 2, 2025
Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems generally good.

Removed some obvious comments, keeping only the specific ones about the dropdowns
removed isOpen variable that was used only once
@Vmarcelo49
Copy link
Contributor Author

I corrected wrong licence
Removed some obvious comments, keeping only the specific ones about the dropdowns
removed isOpen variable that was used only once

Now the code seems pretty clean

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry I've not approved yet)

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hajimehoshi hajimehoshi merged commit 4400d03 into ebitengine:main Jul 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants