Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Nov 14, 2025

possible

In eclipse-platform/eclipse.platform.ui#3517 we discuss which automatic clean-ups we should add. This is the result of a manual run in eclipse-platform to see if this clean-up has issues. Also by running it manually before enabling the clean-ups we avoid creating PR per bundle.

@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

Clean-up has issues eclipse-platform/eclipse.platform.ui#3544

@vogella vogella closed this Nov 14, 2025
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Nov 14, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
team/bundles/org.eclipse.team.core/META-INF/MANIFEST.MF
ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
ua/org.eclipse.ua.tests/META-INF/MANIFEST.MF
ua/org.eclipse.ua.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 94b68dcb0e4178cff363be9b7da453668e41ad47 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 3 Jan 2026 17:57:52 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF b/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
index c14ad5fe8e..8a4359cd84 100644
--- a/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
+++ b/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ant.ui; singleton:=true
-Bundle-Version: 3.10.300.qualifier
+Bundle-Version: 3.10.400.qualifier
 Bundle-Activator: org.eclipse.ant.internal.ui.AntUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/team/bundles/org.eclipse.team.core/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.team.core/META-INF/MANIFEST.MF
index e3d5ba8e73..0a67c9ef3d 100644
--- a/team/bundles/org.eclipse.team.core/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.team.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.team.core; singleton:=true
-Bundle-Version: 3.10.900.qualifier
+Bundle-Version: 3.10.1000.qualifier
 Bundle-Activator: org.eclipse.team.internal.core.TeamPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
index 7593a41764..31c1079a58 100644
--- a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %help_system_plugin_name
 Bundle-SymbolicName: org.eclipse.help.ui; singleton:=true
-Bundle-Version: 4.8.200.qualifier
+Bundle-Version: 4.8.300.qualifier
 Bundle-Activator: org.eclipse.help.ui.internal.HelpUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/ua/org.eclipse.ua.tests/META-INF/MANIFEST.MF b/ua/org.eclipse.ua.tests/META-INF/MANIFEST.MF
index 6764b8072c..3ac5e35883 100644
--- a/ua/org.eclipse.ua.tests/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.ua.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: User Assistance Test
 Bundle-SymbolicName: org.eclipse.ua.tests;singleton:=true
-Bundle-Version: 3.7.300.qualifier
+Bundle-Version: 3.7.400.qualifier
 Require-Bundle: org.eclipse.help.ui,
  org.eclipse.help.webapp,
  org.eclipse.test.performance,
diff --git a/ua/org.eclipse.ua.tests/pom.xml b/ua/org.eclipse.ua.tests/pom.xml
index ac07894724..1d8d087abe 100644
--- a/ua/org.eclipse.ua.tests/pom.xml
+++ b/ua/org.eclipse.ua.tests/pom.xml
@@ -19,7 +19,7 @@
   </parent>
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.ua.tests</artifactId>
-  <version>3.7.300-SNAPSHOT</version>
+  <version>3.7.400-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@vogella vogella reopened this Nov 14, 2025
@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

Clean-up has issues eclipse-platform/eclipse.platform.ui#3544

No this one is fine, thanks to verification from @merks

@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

Converrting to draft, as IMHO we should not apply such clean-ups shortly before a release.

@vogella vogella marked this pull request as draft November 14, 2025 10:09
@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2025

These changes also look fine to me.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Test Results

 1 956 files  ±0   1 956 suites  ±0   1h 31m 13s ⏱️ - 3m 2s
 4 743 tests ±0   4 719 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 229 runs  ±0  14 047 ✅ ±0  182 💤 ±0  0 ❌ ±0 

Results for commit 5570235. ± Comparison against base commit fe29dc3.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

Do you plan to finish this one?

@akurtakov akurtakov force-pushed the string-replace-cleanup branch from 53af68d to 91c4c95 Compare December 12, 2025 05:47
@vogella vogella marked this pull request as ready for review December 12, 2025 08:29
@vogella vogella force-pushed the string-replace-cleanup branch 2 times, most recently from 2f12095 to 177c7e2 Compare December 18, 2025 09:07
possible

In eclipse-platform/eclipse.platform.ui#3517
we discuss which automatic clean-ups we should add. This is the result
of a manual run in eclipse-platform to see if this clean-up has
issues. Also by running it manually before enabling the clean-ups we
avoid creating PR per bundle.
@vogella vogella force-pushed the string-replace-cleanup branch from 177c7e2 to 33971e6 Compare January 3, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants