-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Allow wildcard matching of service account subject #8629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wildcard matching of service account subject #8629
Conversation
|
Example: eksctl create iamserviceaccount \
--name crossplane \
--namespace crossplane-system \
--cluster "$CLUSTER_NAME" \
--role-name "$ROLE_NAME" \
--attach-policy-arn 'arn:aws:iam::aws:policy/AdministratorAccess' \
--subject-pattern 'provider-aws-*' \
--role-only \
--approve |
NicholasBlaskey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature looks reasonable to me. Thanks for contributing a fix
Implementation looks good to me just have a comment couples
5a85c17 to
8856e00
Compare
8856e00 to
6eaa20b
Compare
|
@NicholasBlaskey I've regenerated the schema, I believe my PR is now ready, please have a look |
NicholasBlaskey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for contributing
Description
This PR adds
--subject-patterntoeksctl create iamserviceaccount.#8628
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯