Add missing kms permissions to ElastioAssetAccountDeployer
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
changed the title
kms:* to ElastioAssetAccountDeployerkms permissions to ElastioAssetAccountDeployer
vsazhenyuk-softheme
approved these changes
Mar 28, 2025
babinskiy
approved these changes
Mar 28, 2025
| module "elastio_policies" { | ||
| source = "terraform.cloudsmith.io/public/elastio-iam-policies/aws" | ||
| version = "0.33.1" | ||
| version = "0.33.2" |
Contributor
There was a problem hiding this comment.
I guess, we can use the latest version in the README and examples
Contributor
Author
There was a problem hiding this comment.
I'd keep the exact version to make it easier for the users. I'm pretty sure they'll copy the latest version if we don't specify an exact one here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add
kmspermissions to the deployer role, which are required ifencryptWithCmkis enabled.