Implement structured subset params support #3629
Open
+761
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yExpr) Add support for structured expressions in subset queries to enable proper columnMapper transformations for column names. This enables TanStack DB to send structured expression data alongside compiled SQL strings. Changes: - Add SerializedExpression and SerializedOrderByClause types - Add compileExpression() and compileOrderBy() functions for expression compilation - Update SubsetParams to include whereExpr and orderByExpr fields - Update client to prefer structured expressions when available - Add new query params: subset__where_expr, subset__order_by_expr When structured expressions are provided, the client compiles them with columnMapper applied, allowing transformations like camelCase → snake_case to work correctly for subset queries.
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3629 +/- ##
==========================================
+ Coverage 87.79% 87.81% +0.02%
==========================================
Files 18 19 +1
Lines 1663 1740 +77
Branches 415 458 +43
==========================================
+ Hits 1460 1528 +68
- Misses 201 210 +9
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on TanStack/db#1042
Add support for structured expressions in subset queries to enable proper columnMapper transformations for column names. This enables TanStack DB to send structured expression data alongside compiled SQL strings.
Changes:
When structured expressions are provided, the client compiles them with columnMapper applied, allowing transformations like camelCase → snake_case to work correctly for subset queries.