-
Notifications
You must be signed in to change notification settings - Fork 89
FE: Filter consent manual task condition fields #7313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: Filter consent manual task condition fields #7313
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Update AddEditConditionModal.tsx
ad26601 to
ccd1ed5
Compare
ccd1ed5 to
f8ca841
Compare
Greptile OverviewGreptile SummaryThis PR filters manual task condition field options based on configured request types. When only consent tasks are configured, the UI hides dataset field sources (consent DSRs don't have data flow between nodes) and filters out privacy request fields like Key implementation details:
The implementation properly addresses the issue raised in the previous thread about state initialization - the Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 1 comment
clients/admin-ui/src/features/integrations/configure-tasks/AddConditionForm.tsx
Show resolved
Hide resolved
|
@greptile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, 1 comment
Additional Comments (1)
|
|
@greptile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, no comments
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in preview and looks good!
Ticket ENG-2412
Description Of Changes
Filtered manual task condition field options based on configured request types. Consent manual tasks cannot use dataset field conditions (no data flow in consent DSRs) and certain privacy request fields like
due_date(no execution timeframe). When only consent tasks are configured, the UI now hides unavailable field options. When both consent and access/erasure tasks exist, a warning banner explains the limitations.Code Changes
CONSENT_ALLOWED_PRIVACY_REQUEST_FIELDSconstant excludingdue_datefielduseConfiguredRequestTypeshook to detect which request types have tasks configuredPrivacyRequestFieldPickerto filter fields whenisConsentOnlyis trueAddConditionFormto hide dataset field source option for consent-only configurationsTaskConditionsTabto show warning banner for mixed consent + access/erasure configurationsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated