Skip to content

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Feb 6, 2026

Ticket ENG-2216

Description Of Changes

Adds Cypress tests for Okta monitor UI functionality.

Steps to Confirm

  1. CI passes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner February 6, 2026 22:15
@jpople jpople requested review from speaker-ender and removed request for a team February 6, 2026 22:15
@vercel
Copy link
Contributor

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 9, 2026 8:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 9, 2026 8:43pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 6, 2026

Greptile Overview

Greptile Summary

  • Adds Cypress E2E coverage for Action Center infrastructure systems (search, filters, selection, and bulk actions) using new fixtures and stubs.
  • Extends Cypress stubbing helpers to support dynamic fixture selection based on query params and adds dedicated stubs for filter and bulk-action endpoints.
  • Introduces multiple new JSON fixtures to represent empty, searched, filtered, ignored, and large-dataset result sets.
  • Main merge blockers are test flakiness risks: URL substring assertions, non-deterministic waiting on repeated intercepted requests, and brittle checkbox selectors; plus a likely-non-matching intercept for the filters endpoint in stubs.ts.

Confidence Score: 3/5

  • This PR is reasonably safe to merge once the Cypress tests are made deterministic and the filter intercept matcher is fixed.
  • The changes are isolated to Cypress tests and stubs, but several new assertions depend on request ordering and DOM ordering, and one new intercept matcher is likely too specific to reliably match real requests—these will cause CI flakiness if not addressed.
  • clients/admin-ui/cypress/e2e/action-center/infrastructure-systems.cy.ts, clients/admin-ui/cypress/support/stubs.ts

Important Files Changed

Filename Overview
clients/admin-ui/cypress/e2e/action-center/infrastructure-systems.cy.ts Adds extensive Cypress coverage for infrastructure systems UI (search/filter/selection/bulk actions); includes a few brittle assertions (URL substring, assuming request order, checkbox index selectors) that can cause flakiness.
clients/admin-ui/cypress/fixtures/detection-discovery/results/infrastructure-systems-filters.json Adds filters fixture used by UI filter dropdowns (data_uses/vendors).
clients/admin-ui/cypress/fixtures/detection-discovery/results/infrastructure-systems-large-dataset.json Adds large-dataset fixture used to exercise select-all/bulk actions with filters and exclusions.
clients/admin-ui/cypress/fixtures/detection-discovery/results/infrastructure-systems-searched.json Adds searched results fixture for infrastructure systems search scenarios.
clients/admin-ui/cypress/support/stubs.ts Extends infrastructure systems stub to support dynamic responses and adds new stubs for filters and bulk actions; filter stub URL matching is likely too specific and may not intercept correctly.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@jpople jpople added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit eed700e Feb 10, 2026
44 of 46 checks passed
@jpople jpople deleted the jpople/eng-2216/okta-monitor-tests branch February 10, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants