Skip to content

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Feb 6, 2026

Ticket ENG-2473

Description Of Changes

Removes all Helios V1-exclusive code I could find and the Helios V2 beta flag, making V2 the default detection-discovery view.

Steps to Confirm

  1. CI passes
  2. Smoke test the action center, ensure working as expected

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner February 6, 2026 22:44
@jpople jpople requested review from gilluminate and removed request for a team February 6, 2026 22:44
@vercel
Copy link
Contributor

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 11, 2026 0:26am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 11, 2026 0:26am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 6, 2026

Greptile Overview

Greptile Summary

  • Removes Helios V1 UI routes/pages (activity, data detection, data discovery) and the associated table components/hooks/tests.
  • Removes the heliosV2 feature flag and makes the Action Center navigation/routes always include the former V2 functionality.
  • Updates Action Center and monitor configuration UI to no longer gate datastore/LLM-classifier features behind the beta flag.
  • Risk: a couple of remaining enablement checks still depend on webMonitor/oktaMonitor, which may block datastore-only setups or cause aggregate-results queries to error if the backend expects only enabled monitor types.

Confidence Score: 3/5

  • This PR is likely mergeable but has a couple of functional gating issues that can break datastore-only Action Center access.
  • Most changes are deletions/flag removal and appear internally consistent (no remaining references to removed routes/flags). However, MonitorList still disables the page when webMonitor/oktaMonitor are off despite always including datastore monitors, and the action-center index now always filters for datastore monitor types, which can cause API errors depending on backend behavior.
  • clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx; clients/admin-ui/src/pages/data-discovery/action-center/index.tsx

Important Files Changed

Filename Overview
clients/admin-ui/cypress/e2e/discovery-detection.cy.ts Deleted legacy Helios V1 Cypress E2E coverage for discovery/detection/activity pages; ensure equivalent coverage exists for the new Action Center views.
clients/admin-ui/src/features/common/nav/nav-config.tsx Removed nav entries for legacy discovery/detection/activity pages and removed heliosV2 flag gating; Action center now only requires webMonitor flag.
clients/admin-ui/src/features/common/nav/routes.ts Removed route constants for legacy discovery/detection/activity pages.
clients/admin-ui/src/features/data-discovery-and-detection/DiscoveryMonitorBreadcrumbs.tsx Removed breadcrumb component, leaving only exported DATA_BREADCRUMB_ICONS for dataset pages.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/ActionCenterLayout.tsx Removed heliosV2 feature flag check; Action center now disabled solely based on webMonitor flag.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx Always includes datastore monitor type but still gates page availability on webMonitor/oktaMonitor flags, which can make datastore-only setups unreachable.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useActionCenterNavigation.tsx Always includes Activity route in action center navigation (removed heliosV2 conditional).
clients/admin-ui/src/features/integrations/configure-monitor/ConfigureMonitorForm.tsx Removed heliosV2 flag gating and always fetches configuration settings; LLM classifier option now shown for non-infrastructure monitors unconditionally.
clients/admin-ui/src/flags.json Removed heliosV2 feature flag definition.
clients/admin-ui/src/pages/data-discovery/action-center/datastore/[monitorId]/index.tsx Removed heliosV2 access guard and HELIOS_ACCESS_ERROR constant; datastore monitor page always accessible.
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx Always includes datastore monitor type in aggregate-results query filter; may error if API expects only enabled monitor types.
clients/admin-ui/src/pages/data-discovery/action-center/infrastructure/[monitorId]/index.tsx Removed heliosV2 access guard and HELIOS_ACCESS_ERROR constant; infrastructure monitor page always accessible; retains API error handling.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 6, 2026

Additional Comments (1)

clients/admin-ui/src/pages/data-discovery/action-center/index.tsx
Backend filter may exclude results

This page now always includes MONITOR_TYPES.DATASTORE in the monitor_type filter (even when other monitor types are disabled). If the backend rejects unknown/disabled monitor types or uses feature flags to gate datastore monitoring, this can cause the initial useGetAggregateMonitorResultsQuery call to error and render the ErrorPage even though the user might still be able to use the action center for other enabled monitors.

Make the monitor_type list reflect only actually-enabled monitor types (or confirm the API accepts datastore unconditionally).

Merged via the queue into main with commit 010cb49 Feb 11, 2026
44 of 46 checks passed
@jpople jpople deleted the jpople/eng-2473/remove-helios-v1 branch February 11, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants