Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 9, 2026

Ticket ENG-2429

Description Of Changes

Updates the system information form to use the formatUser function to display data stewards for consistency.

Code Changes

Steps to Confirm

  1. Create a new system
  2. Verify that the data steward input functions correctly
  3. Confirm that the values in the data stewards selection are formatted the same as the input in the monitor config form (defaults to first + last name if available)

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 11, 2026 2:29pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 11, 2026 2:29pm

Request Review

@speaker-ender speaker-ender force-pushed the refactor/system-user-formatting--ENG-2429 branch from 39baa24 to 9a57a30 Compare February 9, 2026 17:22
@speaker-ender speaker-ender force-pushed the refactor/system-user-formatting--ENG-2429 branch from 9a57a30 to e07e055 Compare February 9, 2026 21:09
@speaker-ender speaker-ender changed the title refactor: system user formatting [ENG-2429] refactor: system data steward input formatting [ENG-2429] Feb 10, 2026
@speaker-ender speaker-ender force-pushed the refactor/system-user-formatting--ENG-2429 branch from e07e055 to dfd4122 Compare February 10, 2026 14:44
@speaker-ender speaker-ender marked this pull request as ready for review February 10, 2026 15:56
@speaker-ender speaker-ender requested a review from a team as a code owner February 10, 2026 15:56
@speaker-ender speaker-ender requested review from gilluminate and removed request for a team February 10, 2026 15:56
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR standardizes how data steward users are displayed in the System Information form by switching the select option label from user.username to the shared formatUser() helper (consistent with other admin-ui forms).

It also adds a changelog entry for the refactor/change.

Confidence Score: 4/5

  • This PR is safe to merge after addressing a small changelog hygiene issue.
  • The functional change is a minimal refactor (reusing an existing formatting helper) and is consistent with other call sites. The only clear fix needed is removing the template comment header from the new changelog YAML so it doesn’t leak into release notes.
  • changelog/7344.yaml

Important Files Changed

Filename Overview
changelog/7344.yaml Adds a changelog entry for PR #7344, but it still includes the template comment header that should be removed before release generation.
clients/admin-ui/src/features/system/SystemInformationForm.tsx Updates data steward select option labels to use shared formatUser() for consistent display formatting; change is localized and aligns with existing usage elsewhere.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender force-pushed the refactor/system-user-formatting--ENG-2429 branch from 7730d2a to f2d1e2f Compare February 11, 2026 02:53
@speaker-ender speaker-ender added this pull request to the merge queue Feb 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2026
chore: lint and formatting

chore: update changelog

chore: changelog update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants