Skip to content

Conversation

@galvana
Copy link
Contributor

@galvana galvana commented Feb 9, 2026

Description Of Changes

Updating enum for event audit types

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@galvana galvana requested a review from a team as a code owner February 9, 2026 20:11
@galvana galvana requested review from johnewart and removed request for a team February 9, 2026 20:11
@vercel
Copy link
Contributor

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 10, 2026 0:44am
fides-privacy-center Ignored Ignored Feb 10, 2026 0:44am

Request Review

@galvana galvana requested review from thabofletcher and removed request for johnewart February 9, 2026 20:11
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 9, 2026

Greptile Overview

Greptile Summary

This PR updates the EventAuditType enum in src/fides/api/models/event_audit.py to include new privacy assessment-related audit event strings (create/delete and answer update/revert). The EventAudit model persists event_type as a plain String, so the change primarily expands the set of canonical constants used by the rest of the codebase when emitting audit events, without requiring a DB migration.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change only adds new enum constants used as canonical event type strings; it does not modify persistence (event_type remains a String), query logic, or migrations. No behavioral changes beyond enabling additional audit event labels.
  • No files require special attention

Important Files Changed

Filename Overview
src/fides/api/models/event_audit.py Adds new EventAuditType enum values for privacy assessment events; change is localized to constants and does not affect runtime behavior beyond allowing new event_type values.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@thabofletcher thabofletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @galvana!

@galvana galvana added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit d7d76cb Feb 10, 2026
54 of 55 checks passed
@galvana galvana deleted the updating-event-audit-types branch February 10, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants