-
Notifications
You must be signed in to change notification settings - Fork 89
Fix boolean input handling in integration form #7349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boolean input handling in integration form #7349
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryFixed boolean form field handling for integration configuration by converting backend boolean values to strings that match the select component options ( Key changes:
The fix addresses an issue where boolean fields like Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
clients/admin-ui/src/features/integrations/add-integration/ConfigureIntegrationForm.tsx
Show resolved
Hide resolved
jpople
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test locally-- slightly cursed behavior but working as intended, looks good to me.
Ticket ENG-2115
Description Of Changes
Fixes an issue where the boolean form values were not being preloaded correctly upon editing an integration connection. The root issue was working with boolean values from the backend while the frontend options used strings.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works