Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Feb 9, 2026

Ticket ENG-2115

Description Of Changes

Fixes an issue where the boolean form values were not being preloaded correctly upon editing an integration connection. The root issue was working with boolean values from the backend while the frontend options used strings.

Code Changes

  • Converts booleans to strings to match the select options
  • Converts booleans/numbers to string to check for unchanged secrets

Steps to Confirm

  1. Go to Settings > Integrations page
  2. Add a MySQL database integration (not AWS or Cloud)
  3. Fill the connection data and select SSH required as True
  4. Save the integration
  5. In the integration detail, click Configure and check that the "SSH required" field shows True
  6. Try changing that to False, saving and reopening the form
  7. Open Developer Tools and the network tab
  8. Open the modal again but this time only change the Description
  9. Save the form. You should not see any network call to update the secrets because only the Description field was updated

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@lucanovera lucanovera requested a review from a team as a code owner February 9, 2026 20:11
@lucanovera lucanovera requested review from jpople and removed request for a team February 9, 2026 20:11
@vercel
Copy link
Contributor

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 9, 2026 8:12pm
fides-privacy-center Ignored Ignored Feb 9, 2026 8:12pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 9, 2026

Greptile Overview

Greptile Summary

Fixed boolean form field handling for integration configuration by converting backend boolean values to strings that match the select component options ("true"/"false").

Key changes:

  • Converts boolean values from the backend to strings when initializing form values to properly populate select dropdowns
  • Updates the unchanged secrets detection logic to convert both values to strings before comparison to handle booleans and numbers correctly

The fix addresses an issue where boolean fields like ssh_required in MySQL integrations weren't being pre-populated correctly when editing existing connections. Pydantic v2 on the backend will automatically coerce the string values back to booleans when validating the schema.

Confidence Score: 4/5

  • This PR is safe to merge with low risk
  • The fix correctly addresses the boolean-to-string conversion issue for form fields. Pydantic v2's automatic type coercion will handle converting strings back to booleans on the backend. The change is minimal, focused, and fixes a clear bug with boolean field pre-population. One concern about type handling in preprocessValues was noted but doesn't block merging.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/integrations/add-integration/ConfigureIntegrationForm.tsx Converts boolean values to strings for form compatibility, but missing conversion back to booleans when submitting to backend

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally-- slightly cursed behavior but working as intended, looks good to me.

@lucanovera lucanovera added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit b87ed11 Feb 10, 2026
46 checks passed
@lucanovera lucanovera deleted the ENG-2115-Integrations-UI-shows-blank-forms-for-boolean-fields branch February 10, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants