-
Notifications
You must be signed in to change notification settings - Fork 461
feat: add auto-export settings for notes and transcript #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ript - Add auto_export_summary, auto_export_memo, auto_export_transcript settings - Update localPersister2 to support transcript export using exportToVtt - Add UI toggles in export settings to control each export type - Update jsonPersister to include data section in settings - Use Set for O(1) transcript ID lookups in getWordsForSession Co-Authored-By: yujonglee <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…rt_transcript) - Replace auto_export_summary and auto_export_memo with single auto_export_notes - Update localPersister2 to use isNotesEnabled instead of separate checks - Simplify export.tsx UI to show only 2 toggles (Notes and Transcript) Co-Authored-By: yujonglee <[email protected]>
Resolve merge conflicts: - Integrate transcript export with new batch export system in localPersister2 - Update AutoExportOptions to use simplified notes/transcript structure - Keep saveTranscriptToFile function for VTT export Co-Authored-By: yujonglee <[email protected]>
Co-Authored-By: yujonglee <[email protected]>
Summary
Adds granular control over auto-export functionality with two settings:
auto_export_notes(for summaries and memos) andauto_export_transcript(for VTT subtitle files). The transcript export uses the existingexportToVttcommand.Changes:
auto_export_notes,auto_export_transcriptunder thedatasection in settings.jsonlocalPersister2with a newAutoExportOptionsinterface and transcript export handlergetWordsForSessionhelper to collect words for a session's transcriptsUpdates since last revision
localPersister2to use the new batch export system (exportTiptapJsonToMdBatch)speakerproperty to VttWord objects ingetWordsForSession(required by updated VttWord type)undefinedfor the optionalhandlePersistTranscriptparameter before the options objectReview & Testing Checklist for Human
getWordsForSessionfunction setsspeaker: (word.speaker as string) ?? null- verify this works correctly with actual transcript data (speaker may not always be populated)!== falsecheck).Recommended test plan:
.vttfileNotes
getWordsForSessionfunction uses@ts-ignorefor dynamic table access - this follows the existing pattern in the codebase but reduces type safety