feat: add support for zeroize in scalar type #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stebalien is this something you could review? |
Stebalien
reviewed
Dec 8, 2025
Stebalien
approved these changes
Dec 8, 2025
Member
|
@Kubuxu this LGTM, but you'll have to merge/release. NOTE: zeroize is already in the dependency tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for zeroizing the Scalar values following the
zeroizecrate. Unfortunately the underlying type of the Scalar type in this crateblst_frdoes not implement theZeroizetrait, so the PR implements it manually using unsafe code.If the underlying type was
blst_scalar, the task would have been trivial because that type does implementZeroize. I know the difference between these two was discussed in the past: #10. Just wanted to mention that the lack of zeroize upstream forblst_frseems to point to the fact thatblst_scalarshould have been used instead.