refactor: completely rewrite SqlTemplate with intelligent SQL parsing and batching#776
Closed
refactor: completely rewrite SqlTemplate with intelligent SQL parsing and batching#776
Conversation
dieppa
requested changes
Dec 31, 2025
Member
dieppa
left a comment
There was a problem hiding this comment.
Really good start and a solid foundation (the intent is clear and the tests are a great base).
I don’t think we can merge this approach as it stands, mainly because it rewrites SQL and that can break semantics.
Given the long tail of edge cases, I’d prefer we reuse a battle-tested OSS splitter instead (either as a dependency, or by forking/embedding the relevant code so we own it). I’m totally fine maintaining a fork if that’s the direction we choose.
Also: I like where this is going — the end goal should include supporting procedures / blocks, but we can treat that as a v2 once the DDL/DML splitting is rock-solid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.