Skip to content

Update local-execution to newest task-spec #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elliottslaughter wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Update local-execution to newest task-spec #1625

elliottslaughter wants to merge 48 commits into from
+1,007 −1,770

Conversation

@elliottslaughter
Copy link
Contributor

@elliottslaughter elliottslaughter commented Jan 17, 2026 •
edited
Loading

Currently running end-to-end tests, except for (unimplemented) loss function.

Changes to local-execution:

  • ComputationGraphInstance now captures all the necessary state to run a computation
    • InitializedComputationGraphInstance has been removed
    • Creating the ComputationGraphInstance runs all passes, allocates and initializes the graph
  • local_task_registry.h is now static: no dynamic map is retained
    • This means task IDs are no longer used or required
  • LocalCostEstimator is temporarily disabled
  • Irrelevant sections of the old runtime have been removed

Changes to task-spec:

  • DynamicValueAttrs now stores a DynamicTensorAccessor (variant of GenericTensorAccessorR and GenericTensorAccessorW)
  • Exposed the mapping computed from labelled_open_kwarg_dataflow_graph_from_dynamic_open_dataflow_graph
  • Fixes for make_dynamic_open_dataflow_graph_from_cg
  • Fixes for perform_update_insertion
  • Fixes for linear op and optimizer wrappers

This change is Reviewable

@elliottslaughter
Rip out a bunch of stuff, stub stuff out.
e6a3202
@elliottslaughter
Basic flow to create computation graph instance: computation graph to…
4195ffa 
… equivalent dataflow, expand.
@elliottslaughter
Initialized computation graph instance owns input tensors.
7c0f034 
Refactor computation graph instance as DTG.

Cut out more stuff that doesn't compile yet.
@elliottslaughter
Factor out dynamic_layer_guid_t and some work on make_dynamic_open_da…
98b2a22 
…taflow_graph_from_cg.
@elliottslaughter
Create initialized computation graph instance.
56d7736
@elliottslaughter
Assert on state of computation graph.
cd0c75e
@elliottslaughter
Switch to variant to track pre-allocated tensors.
624ff44
@elliottslaughter
Code to initialize ops, need task argument accessor.
d01e6b6
@elliottslaughter
Fix up LocalTaskArgumentAccessor.
4f3dbf1
@elliottslaughter
Fix some headers.
7d85b97
@elliottslaughter
Local executor builds, does not link.
01b10d1
@elliottslaughter
Rewrite to use existing tensor allocator pass.
6d049fb
@elliottslaughter
Fix multiple definition.
d2e30a3
@elliottslaughter
Fix up some tests or comment them out.
0158865
@elliottslaughter
Rip out task registry class, stub the static implementation.
dee86af
@elliottslaughter
Implement task IDs.
bd853ed
@elliottslaughter
Rename computation graph instance.
94e8d93
@elliottslaughter
Clean up includes.
704ac90
@elliottslaughter
Fix accessor test.
b11f66e
@elliottslaughter
Fixes for various test cases.
381fbad
@elliottslaughter
Remove obsolete sections of task argument accessor test.
7260781
@elliottslaughter
First pass attempt to generate topological order for dataflow graph.
1787330
@elliottslaughter
Finish implementation of graph execution.
e514b80
@elliottslaughter
Refactor and lift topo order to initialization.
26707d7
@elliottslaughter
Clean up and more implementation.
b48e8c9
@elliottslaughter
Call task implementation.
3439baf
@elliottslaughter
Get everything to build and link.
0772529
@elliottslaughter
Implement rest of passes.
59edd07
@elliottslaughter
Update step.
6f4e2c0
@elliottslaughter
Refactor and simplify.
d3a334c
@elliottslaughter elliottslaughter marked this pull request as ready for review January 29, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@elliottslaughter