Translation and New entities (Closes #185, Closes #330)#341
Translation and New entities (Closes #185, Closes #330)#341MatheusPortes wants to merge 234 commits intogenshindev:mistressfrom
Conversation
fruitful-hook, mountain-bracing-bolt, peak-patrol-song, ring-of-yaxche, sequence-of-solitude, silvershower-heartstrings, starcaller's-watch, sturdy-bone, sunny-morning-sleep-in, surf's-up, symphonist-of-scents, tamayuratei-no-ohanashi, tome-of-the-eternal-flow, vivid-notions, waveriding-whirl
prospector's-drill prototype-amber prototype-starglitter the-dockhand's-assistant
earth-shaker, elegy-for-the-end, emerald-orb, end-of-the-line, engulfing-lightning, everlasting-moonglow, eye-of-perception, fading-twilight, fang-of-the-mountain-king, favonius-codex, favonius-greatsword, favonius-lance, favonius-sword, favonius-warbow, ferrous-shadow, festering-desire, fillet-blade, finale-of-the-deep, fleuve-cendre-ferryman, flower-wreathed-feathers, flowing-purity, flute-of-ezpitzal, footprint-of-the-rainbow
forest-regalia, freedom-sworn, frostbearer, fruit-of-fulfillment, fruitful-hook, hakushin-ring, halberd, hamayumi, haran-geppaku-futsu, harbinger-of-dawn, hunter-s-bow, hunter-s-path, ibis-piercer, iron-point, iron-sting, jadefall-s-splendor
kagotsurube-isshin, kagura-s-verity, katsuragikiri-nagamasa, key-of-khaj-nisut, king-s-squire, kitain-cross-spear, light-of-foliar-incision, lion-s-roar, lithic-blade, lithic-spear, lost-prayer-to-the-sacred-winds, lumidouce-elegy, luxurious-sea-lord, magic-guide, mailed-flower, makhaira-aquamarine, mappa-mare
memory-of-dust, messenger, missive-windspear, mistsplitter-reforged, mitternachts-waltz, moonpiercer, mountain-bracing-bolt, mouun-s-moon, oathsworn-eye, old-merc-s-pal, otherworldly-story, peak-patrol-song, pocket-grimoire, polar-star, portable-power-saw, predator, primordial-jade-cutter, primordial-jade-winged-spear, prospectors-drill, prototype-archaic, prototype-crescent, prototype-rancour, rainslasher, range-gauge, raven-bow, recurve-bow, redhorn-stonethresher, rightful-reward
ring-of-yaxche, royal-bow, royal-greatsword, royal-grimoire, royal-longsword, royal-spear, rust, sacrificial-bow, sacrificial-fragments, sacrificial-greatsword, sacrificial-jade, sacrificial-sword, sapwood-blade, scion-of-the-blazing-sun, seasoned-hunter-s-bow, sequence-of-solitude, serpent-spine, sharpshooter-s-oath, silver-sword, silvershower-heartstrings, skyrider-greatsword, skyrider-sword, skyward-atlas, skyward-blade, skyward-harp, skyward-pride, skyward-spine, slingshot, snow-tombed-starsilver, solar-pearl
song-of-broken-pines, song-of-stillness, splendor-of-tranquil-waters, staff-of-homa, staff-of-the-scarlet-sands, starcaller-s-watch, sturdy-bone, summit-shaper, sunny-morning-sleep-in, surf-s-up, sword-of-descension, sword-of-narzissenkreuz, symphonist-of-scents, talking-stick, tamayuratei-no-ohanashi, the-alley-flash, the-bell, the-black-sword, the-catch, the-dockhands-assistant, the-first-great-magic, the-flute, the-stringless, the-unforged, the-viridescent-hunt, the-widsith, thrilling-tales-of-dragon-slayers, thundering-pulse, tidal-shadow, tome-of-the-eternal-flow
toukabou-shigure, traveler-s-handy-sword, tulaytullah-s-remembrance, twin-nephrite, ultimate-overlord-s-mega-magic-sword, uraku-misugiri, verdict, vivid-notions, vortex-vanquisher, wandering-evenstar, waster-greatsword, wavebreaker-s-fin, waveriding-whirl, white-iron-greatsword, white-tassel, whiteblind, windblume-ode, wine-and-song, wolf-fang, wolf-s-gravestone, xiphos-moonlight
prototype-amber, prototype-starglitter
MatheusPortes
changed the title
MatheusPortes
changed the title
|
I removed the changes made to the docker file |
man90es
left a comment
man90es
left a comment
There was a problem hiding this comment.
I didn't check all release dates but there are probably more wrong ones
| "nation": "Natlan", | ||
| "affiliation": "Tlalocan", | ||
| "rarity": 4, | ||
| "release": "21-05-2025", |
There was a problem hiding this comment.
He was released on May 07, 2025
| "nation": "Natlan", | ||
| "affiliation": "Teteocan", | ||
| "rarity": 4, | ||
| "release": "30-04-2025", |
There was a problem hiding this comment.
She was released on March 26, 2025
| "nation": "Liyue Harbor", | ||
| "affiliation": "Chenyu Vale", | ||
| "rarity": 4, | ||
| "release": "22-01-2025", |
There was a problem hiding this comment.
She was released on January 21, 2025
| "nation": "Natlan", | ||
| "affiliation": "Huitztlan", | ||
| "rarity": 5, | ||
| "release": "22-01-2025", |
There was a problem hiding this comment.
She was released on January 01, 2025
|
Okay, |
Some characters get released mid-version, here's the list of banners: https://genshin-impact.fandom.com/wiki/Wish/History |
Skirk, Dahlia
Dahlia, Skirk
|
I made the release date changes based on this page: https://genshin-impact.fandom.com/wiki/Character/List#Characters_by_Release_Date I took the opportunity to add entities and translations of 2 characters that were missing. |
man90es
left a comment
man90es
left a comment
There was a problem hiding this comment.
I suspect there are many more mistakes in this PR aside from the ones I indicated. Including but not limited to character release dates -- those were just the easiest for me to point out. Please don't make me point out each of them. And if we want to have an updated database sooner -- the best approach would be to have smaller, more targeted pull requests instead of one that changes over 300 files.
| "nation": "Natlan", | ||
| "affiliation": "Tlalocan", | ||
| "rarity": 5, | ||
| "release": "04-12-2024", |
There was a problem hiding this comment.
Chasca was released on November 20, 2024 https://genshin-impact.fandom.com/wiki/Chasca
| "nation": "Natlan", | ||
| "affiliation": "Mictlan", | ||
| "rarity": 5, | ||
| "release": "2025-01-22", |
There was a problem hiding this comment.
Citlali was released on January 01, 2025 https://genshin-impact.fandom.com/wiki/Citlali
| "nation": "Fontaine", | ||
| "affiliation": "Fontaine", | ||
| "rarity": 5, | ||
| "release": "21-05-2025", |
There was a problem hiding this comment.
Escoffier was released on May 07, 2025 https://genshin-impact.fandom.com/wiki/Escoffier
|
The information was taken from the official Hoyolab website # https://wiki.hoyolab.com/pc/genshin/aggregate/2 # except for the dates that are conflicting. I will remove this information and leave only data from the official website, but I have seen incompatibility of information from the official "hoyolab" and fandom websites. |
2 participants
🌐 Translation and New Entities
Context
Some required entities for the application were missing. Additionally, most of the existing entities didn’t have translations to Portuguese, which affected the user experience for Portuguese-speaking users.
What was done
How to test
Related to improvements in the application's internationalization.
Closes #185
Closes #330