Rust: Restrict ImplicitDerefBorrowNode to nodes with enclosing CFG scope
#21161
+40
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/restrict-implicit-deref-borrow-nodes
branch
from
2ec7f37 to
55d4902
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restricts ImplicitDerefBorrowNode instances to only those expressions that have an enclosing CFG scope, addressing data flow inconsistencies identified in DCA issue #34054.
Changes:
- Narrowed type from
AstNodetoExprfor implicit deref/borrow node representations - Added
hasEnclosingCfgScope()guards to node type constructors to ensure proper CFG scope association - Renamed internal methods and variables to reflect the more specific
Exprtype
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/dataflow/internal/Node.qll | Updated ImplicitDerefBorrowNode and related classes to use Expr instead of AstNode, added CFG scope checks in type constructors, and renamed methods/variables accordingly |
| rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll | Updated DataFlowCall methods to use Expr instead of AstNode and added CFG scope check to TImplicitDerefCall constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paldepind
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some data flow inconsistencies, as confirmed by DCA.