Fix #3172: Resolve unusable surveys due to state management issues

[AnuragManu]

Fixes #3172

Fix for Issue #3172: Unusable Surveys

Problem

Users were experiencing issues with surveys becoming unusable in certain scenarios. When attempting to access or complete surveys under specific conditions, the app would fail to properly load or save survey data. This resulted in data collection interruptions and potential data loss for field workers who rely on the Ground platform for their work.

Solution

This PR addresses the issue by:

1. Root Cause: Identified that the problem was occurring due to improper state management when handling survey data synchronization between offline storage and cloud backend.

2. Implementation Changes:

   • Modified the survey data handling logic to ensure proper state transitions
   • Added validation checks before survey submission to prevent invalid data states
   • Improved error handling to provide meaningful feedback when issues occur
   • Updated the survey loading process to ensure consistent state management across network conditions

3. Code Improvements:

   • Refactored the survey handling logic for better maintainability
   • Added additional logging to help diagnose similar issues in the future
   • Improved test coverage for the affected components

Testing

• Added unit tests to verify the fix and prevent regression

• Manually tested the fix with the following scenarios:

  • Creating and completing surveys while offline
  • Synchronizing data with intermittent connectivity
  • Edge cases that previously triggered the bug
  • Verified behavior across different Android versions

• Verified that surveys remain usable across all tested scenarios

Additional Notes

• This change does not introduce any new dependencies
• No database schema changes were required
• The fix is backward compatible with existing survey data

Fixes #3172

[gino-m]

Nice work, @AnuragManu. Sorry for slow reply, I was out for a while. Can you please send a video of the behavior before and after? I understood we were already showing a message when this occurs, but I could be wrong.