Update target and compile sdk and fix compilation errors

[andreia-ferreira]

Fixes #3515

The targetSdk needed to be updated to 36 this year. Since it seems some version updates depend on having the compileSdk version 36 (#3513), this was updated as well as the targetSdk, since the app is already compliant with it. Some minor nullability issues causing compilation errors were handled.

A sanity check was also done across the app on an emulator with api 36.

@shobhitagarwal1612 @hassan-nsubuga PTAL?

[gemini-code-assist]

Summary of Changes

Hello @andreia-ferreira, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the project's Android SDK versions to 36 for both targetSdk and compileSdk. This update is crucial for maintaining application compatibility and leveraging the latest platform features. Alongside the SDK bumps, several minor compilation warnings, primarily related to nullability, have been resolved to ensure a clean build. The changes have been verified on an API 36 emulator.

Highlights

• Android SDK Update: The targetSdk and compileSdk versions have been updated from 35 to 36 to ensure compatibility with the latest Android platform requirements.
• Compilation Fixes: Addressed minor nullability issues that were causing compilation errors, specifically in AbstractActivity.kt and PhotoTaskFragment.kt.
• Compatibility Verification: A sanity check was performed on an emulator running API 36 to confirm the application's stability after the SDK updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• app/src/main/java/org/groundplatform/android/ui/common/AbstractActivity.kt
  • Made the view parameter in setContentView nullable (View?) to resolve a potential nullability compilation issue.
• app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/photo/PhotoTaskFragment.kt
  • Refactored the capturePhotoLauncher.launch call to directly use the uri variable instead of viewModel.capturedUri, likely addressing a minor compilation warning or improving clarity.
• build.gradle
  • Updated androidCompileSdk from 35 to 36.
  • Updated androidTargetSdk from 35 to 36.

Activity

• Linked to issue [Code health] Update to targetSdk 36 #3515, indicating this PR addresses that specific problem.
• Requested review from @shobhitagarwal1612 and @hassan-nsubuga.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully updates the targetSdk and compileSdk versions to 36, which is a necessary update for the current year. It also addresses minor nullability issues in AbstractActivity.kt and PhotoTaskFragment.kt to resolve compilation warnings. The changes are well-aligned with the pull request description and improve the project's compatibility and code hygiene.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.06%. Comparing base (ac0e1fd) to head (fa52e99).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #3516   +/-   ##
=========================================
  Coverage     70.06%   70.06%           
  Complexity     1600     1600           
=========================================
  Files           322      322           
  Lines          8785     8785           
  Branches        962      962           
=========================================
  Hits           6155     6155           
  Misses         2053     2053           
  Partials        577      577           

Files with missing lines	Coverage Δ
...ui/datacollection/tasks/photo/PhotoTaskFragment.kt	63.23% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.