Conversation
|
I'd personally prefer switching to poetry or pdm right away when we make the switch to pyproject.toml What do you think? @dulmandakh |
|
I use poetry for my projects. I can help with migration too. I'll change the PR to use poetry then 😉 |
|
@erikwrede please review 😉 |
| from .utils.resolve_only_args import resolve_only_args | ||
|
|
||
| __all__ = [ | ||
| "__version__", |
There was a problem hiding this comment.
It's important to keep __version__, as certain extension libraries use it do distignuish between different grapehene releases. I'm fine with deprecation, as python 3.8's importlib.metadata.version('graphene') is a viable alternative. I'd suggest using importlib to fill __version__ and deprecating it, recommending direct use of importlib instead. What do you think? 😊
There was a problem hiding this comment.
I'll look into it and make changes accordingly
| def get_docs_version(version=None): | ||
| version = get_complete_version(version) | ||
| if version[3] != "final": | ||
| return "dev" | ||
| else: | ||
| return "%d.%d" % version[:2] |
There was a problem hiding this comment.
Its also important we keep these in the same format to ensure our docs pipeline doesn't break. Unfortunately, I cannot change much about the way the docs are deployed.
3 participants
This PR migrates legacy packaging to Poetry, making dependency management easy.
Depends on: