Skip to content

Conversation

@ardatan
Copy link
Member

@ardatan ardatan commented Nov 22, 2025

Related ardatan/graphql-tools#7716

Fixes the bug when a GraphQLDirective instance is passed with the same name as specified directives, isSpecifiedDirective returns true unexpectedly.

@ardatan ardatan requested a review from a team as a code owner November 22, 2025 02:02
@vercel
Copy link

vercel bot commented Nov 22, 2025

@ardatan is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@ardatan ardatan force-pushed the is-specified-directive-check-fix branch from a27c4b2 to ebc31f3 Compare November 22, 2025 02:47
@ardatan ardatan marked this pull request as ready for review November 22, 2025 02:47
@ardatan ardatan marked this pull request as draft November 22, 2025 02:53
@yaacovCR
Copy link
Contributor

The spec assumes that all directives with the names of specified directives are the actual specified directives, but it seems to me we should be more permissive as possible within the implementation, especially to enable custom/experimental forms of the different directives.

In terms of future-proofing this, is the contention that we only need one function describing the actual specified directives, or might we need two different functions, one version that retains the current behavior (returning true for custom directives that override the specified ones) and one with the "fixed" behavior?

And basically we have the parallel question with isSpecifiedScalar...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants