Network isolation for deployments (edge + workspace networks)#48
Closed
zbal wants to merge 3 commits intodevelopmentfrom
Closed
Network isolation for deployments (edge + workspace networks)#48zbal wants to merge 3 commits intodevelopmentfrom
zbal wants to merge 3 commits intodevelopmentfrom
Conversation
…or-worker attach in monitor. Add standalone reconcile script
…use network helpers
Collaborator
Author
|
Deprecate in favor of #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Today all runner containers share a single
devpush_runnernetwork, which allows lateral movement between deployments. This change introduces per‑deployment and per‑workspace networks so each deployment is only reachable via its own edge network (for Traefik) and a workspace‑scoped private network (for same‑team traffic).Summary
This introduces a two‑tier network model: an edge network per deployment for Traefik routing and probes, and a workspace network per team for east/west traffic between a team’s deployments. Monitoring attaches to workspace networks on demand, while Traefik attachment is reconciled via a dedicated ARQ task to survive container restarts.
Changes
Network topology:
devpush_edge_<deployment-id>devpush_workspace_<team-id>Runner container wiring:
traefik.docker.networkpoints to the edge networkdevpush.edge_networkanddevpush.workspace_networkMonitoring:
devpush_runnerwhere labels are missingTraefik resiliency:
reconcile_edge_network(scoped by deployment id)Ops tooling:
network-reconcile.shto enqueue reconcile manuallyTesting