You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After working with this library, I realized that I needed a way to filter the contacts based on the the values they had for certain CNKeyDescriptor's. For example, say an app needs to only import contacts which have a valid phone number. By setting the shouldAddContact closure to return true when the phone number for a contact is valid, then you can be sure that the contacts the user can pick from will all have valid phone numbers.
@ipraba: if you don't think this is a good idea, I would love to hear why!
I'm a contributor on this fork as well. I just fixed a bug in reloadContacts() that was causing duplicate contacts to be shown. It seems that the previous implementation of the method was actually just adding the contacts, not reloading them, so if reloadContact() was called twice, all of your contacts would be duplicated. I've set it up now so that it replaces the loaded contacts properly.
We've also changed the filtering closure name from shouldAddContacts to shouldIncludeContacts. I believe this is a clearer description of what this closure does.
This PR should expect no more changes. This has been fully tested and is working for us now in production. If you do want to include this feature, you may merge whenever you are ready. We apologize for the multiple commits post-submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After working with this library, I realized that I needed a way to filter the contacts based on the the values they had for certain
CNKeyDescriptor's. For example, say an app needs to only import contacts which have a valid phone number. By setting theshouldAddContactclosure to returntruewhen the phone number for a contact is valid, then you can be sure that thecontactsthe user can pick from will all have valid phone numbers.@ipraba: if you don't think this is a good idea, I would love to hear why!
Thanks for your time, JF