Conversation
7350341 to
c694fc1
Compare
|
Can't say I agree with the Overwrites for MC-61489, using a ModifyReturnValue with original + height / 3 seems like the easier approach. Or if we really don't want anyone else touching it, a WrapMethod, though not sure that's required. Also TelemetryInfoScreenMixin could be a WrapOperation rather than a Redirect Otherwise the rest looks fine, not that I've tested anything myself but I was in the process of porting when I saw this PR existed, and most of the changes line up exactly with mine. But I did not figure out MC-237493 so :) |
|
@MicrocontrollersDev I also imagine there may be an expression that would be preferable to use over specifying an ordinal, but if so I was unable to figure it out. |
...client/java/dev/isxander/debugify/client/mixins/basic/mc237493/TelemetryInfoScreenMixin.java
Show resolved
Hide resolved
There was a problem hiding this comment.
| @Inject(method = "extractRenderState(Lnet/minecraft/world/entity/animal/squid/Squid;Lnet/minecraft/client/renderer/entity/state/SquidRenderState;F)V", at = @At("TAIL")) |
There was a problem hiding this comment.
Okay don't know why this suggested change also looks weird? The target needs to be updated is all (animal/Squid -> animal/squid/Squid)
There was a problem hiding this comment.
Yeah, figured it out. Weird I never got an error from this.
There was a problem hiding this comment.
Yeah it's one I missed as well in my initial port. It only gives a missing target error warning when launching the game, and god knows how it launches in the first place
Gave my best shot at bypassing the ordinals. There's probably a nicer way to write this Expression but I just know how to write expressions, not how to write good expressions. Also, the original mixin didn't work for me since it tries to cast a Cycle button to a Checkbox, which maybe worked in 1.21.10 but in 1.21.11 made my screen blank whenever I opened the telemetry options button. So this replaces the checkbox button entirely. |
|
I'm very annoyed with myself because I distinctly remember partially porting this myself but I cannot find it on any of my machines!!! |
build.gradle.kts
Outdated
| - Generated by `./gradlew generatePatchedTable` | ||
| - Sourced from `${inputFile.name}` | ||
| - Generated $timestamp | ||
| - Generated now |
There was a problem hiding this comment.
Ah, yes. I was having trouble building:
* What went wrong:
Script compilation errors:
Line 216: val timestamp = `java.time`.LocalDateTime.now().format(`java.time.format`.DateTimeFormatter.ISO_DATE_TIME)
^ Unresolved reference 'LocalDateTime'.
Line 216: val timestamp = `java.time`.LocalDateTime.now().format(`java.time.format`.DateTimeFormatter.ISO_DATE_TIME)
^ Unresolved reference 'DateTimeFormatter'.
This was my fix just so that I could build.
I've removed it.
Port to 1.21.11. Closes #514.
Removes the fixes for MC-22882 and MC-199467, as they were marked as resolved as of 1.21.11.
Includes the fix for armor stands rendering dark (from #509, closes #507) and the corrected description for MC-121903 (#511).
Potential issues:
This PR, like, actually sucks, because: