Add uploadLargeFormFile() for memory-efficient multipart uploads #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
uploadFormFile()loads the whole file into memory before sending. That's fine for small files, but when you're uploading 50-100MB files on an embedded device with 512MB RAM... yeah, not great.I hit this while building a 3D printer touchscreen UI. Uploading large G-code files was causing the whole system to choke.
What this adds
New function
uploadLargeFormFile()- likeuploadFormFile()but streams the file in chunks (same pattern asuploadLargeFile()vsuploadFile()).Memory usage for a 100MB file:
uploadFormFile(): ~100MBuploadLargeFormFile(): ~40KB (just the chunk buffer)Implementation
I extracted a shared helper to avoid duplicating the streaming loop from
uploadLargeFile():internal::streamFileToConnection()helper - extracted fromuploadLargeFile()uploadLargeFile()now uses the shared helper (same behavior, no breaking change)uploadLargeFormFile()for multipart uploads, also uses the shared helperNo breaking changes - existing code works exactly as before.