Fix race between close() and get() in StoreDirect#969
Open
aleksandrserbin wants to merge 1 commit intojankotek:release-3.0from
Open
Fix race between close() and get() in StoreDirect#969aleksandrserbin wants to merge 1 commit intojankotek:release-3.0from
aleksandrserbin wants to merge 1 commit intojankotek:release-3.0from
Conversation
aleksandrserbin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race, when Store is closed, but there are still iterators somewhere, which may use it.
In the concurrent environment,
get()call can passassertNotClosedassertion, but acquire the lock afterStore::closecompleted.Probably linked to #892 as well, if there is a scenario with concurrent
closeandget.Note: this will still lead to exception, however it will be an
IllegalAccessError, rather thenNullPointerException