Fix FFDetrDetector crash when final batch has one page #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
Summary
Fixes a crash in
FFDetrDetector.extract_widgets()when the final batch contains a single page (e.g.len(pages) % batch_size == 1andlen(pages) > 1).Root cause
model.predict()returns:List[sv.Detections]for batch size > 1sv.Detectionsfor batch size == 1When the final batch size is 1,
results.extend(predictions)iterates thesv.Detectionsobject and adds non-detection items (e.g. tuples) intoresults, which later breaks.with_nms().Fix
appendfor singlesv.Detectionsandextendfor lists (ensuresresultsis alwaysList[sv.Detections]).Testing
batch_size=3(batches of 3 + 1).batch_size=1.